From owner-cvs-src@FreeBSD.ORG Fri Dec 14 04:26:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2CB216A417 for ; Fri, 14 Dec 2007 04:26:45 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183]) by mx1.freebsd.org (Postfix) with ESMTP id 804A613C447 for ; Fri, 14 Dec 2007 04:26:45 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1573582waf.3 for ; Thu, 13 Dec 2007 20:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=Hy0kQt224HpFg/du71sbdqvnDf/dX4h0R1nzFZ9yq3s=; b=X+CeCeZ98dx1CrQgT38jEiUR47zodZSFdwpNip5OznwR/mNy7nJNg/FXTuZiYnk2B9GpO4jBUYWIiz/iu5zNVOLeRC8TQ+W+5CzDhp6UQI/15UUCxDNtfQJqbHfeD20LJZ20i7Q36HRhds079EMz0ZPaWhow/zZSB2CWLVLCiZc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=V0MaiNBVylh1FT3t4EcbrtdxaEiez9jwioS4mnYGSSLtMZfox/XDEFV3xZAQF/eEpFsoVN9GM+hCZ5g/FZcEf5c23Tl2TlOVzwJYRfvFyPPejZI1GiXxl/YsmIwQEneUKVQyjvSBDHg61DilcenBfRXVOlpjSbmpxf2hFIRkQVY= Received: by 10.114.130.1 with SMTP id c1mr3224506wad.52.1197606404634; Thu, 13 Dec 2007 20:26:44 -0800 (PST) Received: by 10.114.255.11 with HTTP; Thu, 13 Dec 2007 20:26:44 -0800 (PST) Message-ID: Date: Thu, 13 Dec 2007 20:26:44 -0800 From: "Kip Macy" To: "Julian Elischer" In-Reply-To: <4761BB7C.3010907@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org> Cc: "Bjoern A. Zeeb" , src-committers@freebsd.org, Kip Macy , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2007 04:26:45 -0000 Please review the following change: http://www.fsmware.com/freebsd/tcp/tcp_offload.diff This will replace tcp_ofld.[ch] I'm currently prefixing the dispatch functions that will be added to the actual tcp code with tcp_gen gen == {generic, general}. I'm not attached to the name so if there is a consensus there I will change it. -Kip On Dec 13, 2007 3:08 PM, Julian Elischer wrote: > Bjoern A. Zeeb wrote: > > On Wed, 12 Dec 2007, Kip Macy wrote: > > > > Hi, > > > >> kmacy 2007-12-12 20:21:39 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/conf files > >> sys/netinet tcp_var.h > >> sys/sys socket.h > >> Added files: > >> sys/netinet tcp_ofld.c tcp_ofld.h toedev.h > >> Log: > >> Add driver independent interface to offload active established TCP > >> connections > >> > >> Reviewed by: silby > >> > >> Revision Changes Path > >> 1.1256 +1 -0 src/sys/conf/files > >> 1.1 +126 -0 src/sys/netinet/tcp_ofld.c (new) > >> 1.1 +198 -0 src/sys/netinet/tcp_ofld.h (new) > > I think I'd have just gone for > tcp_offload.c > it's not the longest filename in the system. > > > > > > I consider that just for the archives .. > > > > .. but is there a reason you abbreviated those file names like that? > > It's not like we live with 8.3 contrainsts. > > > > The first time I parsed it as "of ld", then realiazed it should be > > "off ld" and then wondered why it wasn't just "offload" like it is > > "syncache" or "timewait" or "hostcache"? > > > > And yes, I wondered the same about the functions names, ... > > > > Was that spelling inherited from another implementation/standard/whatever? > > > > > > > >> 1.159 +4 -1 src/sys/netinet/tcp_var.h > >> 1.1 +132 -0 src/sys/netinet/toedev.h (new) > >> 1.96 +2 -0 src/sys/sys/socket.h > >> > > > >