From owner-cvs-all Mon Oct 29 9:27:31 2001 Delivered-To: cvs-all@freebsd.org Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by hub.freebsd.org (Postfix) with ESMTP id 94A6137B40A for ; Mon, 29 Oct 2001 09:27:13 -0800 (PST) Received: (qmail 29248 invoked from network); 29 Oct 2001 17:27:12 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 29 Oct 2001 17:27:12 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Mon, 29 Oct 2001 09:27:01 -0800 (PST) From: John Baldwin To: Doug Rabson Subject: Re: cvs commit: src/sys/alpha/alpha trap.c src/sys/i386/i386 tra Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 29-Oct-01 Doug Rabson wrote: > On Fri, 26 Oct 2001, John Baldwin wrote: > >> jhb 2001/10/26 01:12:54 PDT >> >> Modified files: >> sys/alpha/alpha trap.c >> sys/i386/i386 trap.c >> sys/ia64/ia64 trap.c >> sys/kern init_main.c kern_exit.c kern_fork.c >> subr_trap.c >> sys/sparc64/sparc64 trap.c >> sys/sys proc.h >> Log: >> Add a per-thread ucred reference for syscalls and synchronous traps from >> userland. The per thread ucred reference is immutable and thus needs no >> locks to be read. However, until all the proc locking associated with >> writes to p_ucred are completed, it is still not safe to use the >> per-thread >> reference. >> >> Tested on: x86 (SMP), alpha, sparc64 > > This gets horribly confused when I set a DDB breakpoint at the start of > syscall() - it goes into a tight look calling panic because the value of > td_ucred is NULL. Hmm, ok. I'll change the KASSERT() to not fail for kernel trace and breakpoint traps, or something along those lines. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message