From owner-freebsd-arm@FreeBSD.ORG  Mon Feb  9 23:37:16 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1CBBA277
 for <freebsd-arm@freebsd.org>; Mon,  9 Feb 2015 23:37:16 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F14451B6
 for <freebsd-arm@freebsd.org>; Mon,  9 Feb 2015 23:37:15 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t19NbFuV063818
 for <freebsd-arm@freebsd.org>; Mon, 9 Feb 2015 23:37:15 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t19NbF2B063816;
 Mon, 9 Feb 2015 23:37:15 GMT (envelope-from root)
Date: Mon, 9 Feb 2015 23:37:15 +0000
To: freebsd-arm@freebsd.org
From: "ian (Ian Lepore)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D1811: Configure interrupt on ARM when mapped
Message-ID: <8c30084f810d82d180f820f5e8b03dac@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1811: Configure interrupt on ARM when mapped
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-4qcj7rwdmlj6inx42v2r-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-4qcj7rwdmlj6inx42v2r-req@FreeBSD.org>
Thread-Index: M2QzODA2Zjk4MzZkYTA3ZDk2NTI2YmM4NGFiIFTZRKs=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2015 23:37:16 -0000

ian added a comment.

I think this is completely wrong and the interrupt needs to be configured when it is activated, not when it is parsed/decoded.  Consider for example a gpio pin interrupt... we wouldn't want to mess with the pin state while the fdt data is being parsed because that data could refer to a possible configuration which is never going to be activated, and the actual use of the pin in the configuration that is active could be something else (not even related to interrupts).

REVISION DETAIL
  https://reviews.freebsd.org/D1811

To: zbb, andrew, imp, ian
Cc: imp, freebsd-arm