From owner-cvs-src@FreeBSD.ORG Tue Aug 3 07:41:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37FDB16A4CE; Tue, 3 Aug 2004 07:41:32 +0000 (GMT) Received: from tara.freenix.org (keltia.freenix.org [82.224.56.155]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD29A43D3F; Tue, 3 Aug 2004 07:41:31 +0000 (GMT) (envelope-from roberto@keltia.freenix.fr) Received: by tara.freenix.org (Postfix/TLS, from userid 101) id 916972E1C; Tue, 3 Aug 2004 09:41:30 +0200 (CEST) Date: Tue, 3 Aug 2004 09:41:30 +0200 From: Ollivier Robert To: David O'Brien Message-ID: <20040803074130.GA27391@tara.freenix.org> Mail-Followup-To: David O'Brien , src-committers@FreeBSD.org, cvs-src@FreeBSD.org References: <200407201501.i6KF1xVL097253@repoman.freebsd.org> <20040802180135.GB1064@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040802180135.GB1064@dragon.nuxi.com> X-Operating-System: MacOS X / PowerBook G4 - FreeBSD 5.0 / 2x PIII/800 SMP User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/contrib/ntp - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2004 07:41:32 -0000 According to David O'Brien: > Are you willing to work with D.Mills to add an "quiet" flag to ntpdate? > Our boot is now much more verbose with things like: Hmm, last time I checked the ntp-hackers list, ntpdate was supposed to be deprecated (replaced by ntpd -q) although many people complained ntpd was much slower to synchronise and thus ntpdate was still maintained. ntpdate.html has the death warrant: Disclaimer: The functionality of this program is now available in the ntpd program. See the -q command line option in the ntpd - Network Time Protocol (NTP) daemon page. After a suitable period of mourning, the ntpdate program is to be retired from this distribution So I doubt it would be accepted. I'll send a patch to bugzilla.ntp.org anyway. They mix stdout/stderr output which is bad but I won't fix that. --- ntpdate.c.old Tue Jul 20 17:01:41 2004 +++ ntpdate.c Tue Aug 3 09:34:44 2004 @@ -1339,7 +1339,8 @@ hints.ai_family = ai_fam_templ; hints.ai_socktype = SOCK_DGRAM; - printf("Looking for host %s and service %s\n", serv, service); + if (verbose) + printf("Looking for host %s and service %s\n", serv, service); error = getaddrinfo(serv, service, &hints, &addrResult); if (error != 0) { @@ -1348,7 +1349,8 @@ return; } else { - fprintf(stderr, "host found : %s\n", stohost((struct sockaddr_storage*)addrResult->ai_addr)); + if (verbose) + fprintf(stderr, "host found : %s\n", stohost((struct sockaddr_storage*)addrResult->ai_addr)); } server = (struct server *)emalloc(sizeof(struct server)); -- Ollivier ROBERT -=- FreeBSD: The Power to Serve! -=- roberto@keltia.freenix.fr Darwin snuadh.freenix.org Kernel Version 7.4.0: Wed May 12 16:58:24 PDT 2004