From owner-svn-src-head@freebsd.org  Tue Dec  4 08:41:23 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5508A132940C;
 Tue,  4 Dec 2018 08:41:23 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id EF0BB6D521;
 Tue,  4 Dec 2018 08:41:22 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id DE932EC44; Tue,  4 Dec 2018 08:41:22 +0000 (UTC)
Date: Tue, 4 Dec 2018 08:41:22 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Yuri Pankov <yuripv@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r341446 - head/release/amd64
Message-ID: <20181204084122.GB94570@FreeBSD.org>
References: <201812032231.wB3MVvaD060931@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201812032231.wB3MVvaD060931@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: EF0BB6D521
X-Spamd-Result: default: False [0.07 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.05)[-0.053,0];
 NEURAL_SPAM_LONG(0.34)[0.340,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US];
 NEURAL_HAM_SHORT(-0.21)[-0.215,0]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 08:41:23 -0000

On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote:
> New Revision: 341446
> URL: https://svnweb.freebsd.org/changeset/base/341446
> 
> Log:
>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
>   
>   This fixes 'cdrom' target in the case when world was built by user,
>   and not root.

Could you please explain why -p should not have been used here?  I fail
to understand this from the commit log.  I've always considered preserving
various file metadata as a good thing to do, and this commit puzzles me.

./danfe