From nobody Thu May 26 00:48:00 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7DD9E1B3B5B9 for ; Thu, 26 May 2022 00:48:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L7q6S0Frtz4r5c for ; Thu, 26 May 2022 00:48:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DD67B23B99 for ; Thu, 26 May 2022 00:47:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24Q0lxrV090033 for ; Thu, 26 May 2022 00:47:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24Q0lxfv090032 for ports-bugs@FreeBSD.org; Thu, 26 May 2022 00:47:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263090] www/node14: Update to 14.19.3 (includes security fixes) Date: Thu, 26 May 2022 00:48:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: dereks@lifeofadishwasher.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653526080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s+nPAe45+xJbOZIUdkFHh9lX5lrHyxn21ciTPzB++8M=; b=tZgrDCZ8/rLTJQImcLD532PFKcSYrw4tdyqNe1fmrBtsIm7k7tDyWFbO+KGUIdVHbXKJRK /UNNoj1qKBZkAffbYRwLujYNk1ZWjg9ExJC4xVW/EnPnyyhv0MUqw+x1G+16JL9EhKDhH2 zRiB4P1FyFfZxS2Vs6zLsVue5Bqr1uY6jEgAQETazhLUkl1Yat1BSMf7Wjhfb8DUEzjyS9 TUAp8bPHexCmntnAiJo8RqpPcmwjT65SAAPBSgqxQ05nrtyUnRlZ3QXC2LDC8QuXvZx+EE lW3siFfijX0qDiimNFWJsNrAw4JB5AblhOP1++cG4q7k6tMzOd2j/TBmQ06lqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653526080; a=rsa-sha256; cv=none; b=WzJrBB+Zg8aVYmvqcIEoLETgznYJAckcBzQtEXevn0KjYfi0wJj5Zv0tY619g3kuoYOuqt 9pUkaQPlHWvELDS/uiSQcoQlUb1S8iwNIPppF9wn1g8OhdJwAr8pYD9mqwH8gCD+1wJQBk G/Zdm5XfQMQCcj5DcrLJLpNJ2u3r3RvLJzTkNKVazpII1lKKK6/lZECS7hlNeJoHlTclLH /EJoaCDf8MgyTu+Fz9LHJICwKNRSbMy7xwnP/VyDP427/61ifSK22FdbKnSUmBcehLzmt6 DPHiqOZmBQiJF7uqR5oImZq+YsjWnWrflT5Hgiq9ASv8olE5eICt4+SNKOJsPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263090 --- Comment #6 from Derek Schrock --- (In reply to Kubilay Kocak from comment #4) > - Are there performance implications for the ssl patch to node.gyp? There shouldn't be. This is a previous patch reworked for 14.19.x codebase. https://cgit.freebsd.org/ports/tree/www/node14/files/patch-node.gypi?id=3D0= 464754ea1f56c60d43945f6da2d9127a6a80527 > - What is the nature of the COREPACK additional (by default), as it relat= es to and compares to existing functionality of the ports current version? >From my understanding corepack is taking third-party package managers and building them into by a proxy such that don't need to be installed else whe= re.=20 I don't want to say it's the same thing but kinda of ensurepipish...?=20 This is experimental feature and I wanted to disable to by default however given that www/node16 enabled it by default I figured we would follow suit here. > - Depending on the build system design, CONFIGURE_* options can be non de= terministic, and there is no CONFIGURE_ON to match the CONFIGURE_OFF additi= on here. > Did you try COREPACK_CONFIGURE_WITH=3Dcorepack?=20 There isn't a --with-corepack in node configure script so I believe that's = why it's _OFF only and not a _WITH. $ ./configure --with-corepack ; echo $? Node.js configure: Found Python 3.8.13... Usage: configure [options] configure: error: no such option: --with-corepack 2 So unless if upstream changes the script I don't with a _WITH would work he= re. --=20 You are receiving this mail because: You are the assignee for the bug.=