Date: Wed, 3 Feb 1999 21:51:56 -0500 (EST) From: Brian Feldman <green@unixhelp.org> To: current@FreeBSD.ORG Subject: various -CURRENT nits Message-ID: <Pine.BSF.4.05.9902032145170.11781-100000@janus.syracuse.net>
next in thread | raw e-mail | index | archive | help
I've got a few patches today; let's see: The TCB hash check is broken, because ffs() returns offsets starting at 1, not 0. Some of VoxWare doesn't compile. In addition, if anyone thinks it should be done, should I make PQ_L[12]_SIZE config(8) tuneable (individually, not via PQ_FOOCACHE)? I use different values because I have a K6-2 (8+8 pages L1) that does not match PQ_L1_SIZE. I'd also like to readd the comment that CPU_WT_ALLOC might not be stable on a K6-2, because it actually _doesn't_ seem to be stable here. The fixes to the two problems follow. Brian Feldman _ __ ___ ___ ___ green@unixhelp.org _ __ ___ | _ ) __| \ http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ --- src/sys/netinet/tcp_subr.c.orig Wed Feb 3 21:40:42 1999 +++ src/sys/netinet/tcp_subr.c Wed Feb 3 21:42:17 1999 @@ -136,8 +136,8 @@ tcbinfo.listhead = &tcb; if (!(getenv_int("net.inet.tcp.tcbhashsize", &hashsize))) hashsize = TCBHASHSIZE; - if ((1 << ffs(hashsize)) != hashsize) { - printf("WARNING: TCB hash size not a power of 2\n"); + if ((1 << (ffs(hashsize) - 1)) != hashsize) { + printf("WARNING: TCB hash size (%d) not a power of 2\n", hashsize); hashsize = 512; /* safe default */ } tcbinfo.hashbase = hashinit(hashsize, M_PCB, &tcbinfo.hashmask); --- src/sys/i386/isa/sound/os.h.orig Wed Feb 3 20:51:52 1999 +++ src/sys/i386/isa/sound/os.h Wed Feb 3 20:51:47 1999 @@ -18,6 +18,7 @@ #include <sys/malloc.h> #include <sys/buf.h> #include <sys/signalvar.h> +#include <sys/select.h> #include <machine/soundcard.h> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9902032145170.11781-100000>