From owner-freebsd-current@FreeBSD.ORG  Mon Nov 24 15:01:15 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C26C216A4CF
	for <freebsd-current@freebsd.org>;
	Mon, 24 Nov 2003 15:01:15 -0800 (PST)
Received: from pit.databus.com (p70-227.acedsl.com [66.114.70.227])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9E54A43FE9
	for <freebsd-current@freebsd.org>;
	Mon, 24 Nov 2003 15:01:14 -0800 (PST)
	(envelope-from barney@pit.databus.com)
Received: from pit.databus.com (localhost [127.0.0.1])
	by pit.databus.com (8.12.9p2/8.12.9) with ESMTP id hAON17Tb042237;
	Mon, 24 Nov 2003 18:01:07 -0500 (EST)
	(envelope-from barney@pit.databus.com)
Received: (from barney@localhost)
	by pit.databus.com (8.12.9p2/8.12.9/Submit) id hAON16go042236;
	Mon, 24 Nov 2003 18:01:06 -0500 (EST)
	(envelope-from barney)
Date: Mon, 24 Nov 2003 18:01:06 -0500
From: Barney Wolff <barney@databus.com>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20031124230106.GB42006@pit.databus.com>
References: <bptu39$khk$1@sea.gmane.org>
	<20031124220029.GA40910@pit.databus.com>
	<20031124.153542.50239989.imp@bsdimp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031124.153542.50239989.imp@bsdimp.com>
User-Agent: Mutt/1.4.1i
X-Scanned-By: MIMEDefang 2.38
cc: freebsd-current@freebsd.org
Subject: Re: USB 1.0 IDE to ATAPI drive enclosure failure
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2003 23:01:15 -0000

On Mon, Nov 24, 2003 at 03:35:42PM -0700, M. Warner Losh wrote:
> : Why hasn't anything been committed?
> 
> Code freeze?

I understand the concept, but I haven't seen any reports of people
claiming that OHCI works for other than mice/keyboards without
the following patch (from "Brian F. Feldman" <green@freebsd.org>):
--- ohci.c      12 Nov 2003 01:40:11 -0000      1.138
+++ ohci.c      22 Nov 2003 03:28:42 -0000
@@ -569,7 +569,7 @@
                cur->td.td_cbp = htole32(dataphys);
                cur->nexttd = next;
                cur->td.td_nexttd = htole32(next->physaddr);
-               cur->td.td_be = htole32(DMAADDR(dma, curlen - 1));
+               cur->td.td_be = htole32(DMAADDR(dma, offset + curlen - 1));
                cur->len = curlen;
                cur->flags = OHCI_ADD_LEN;
                cur->xfer = xfer;

It cured my problems with a Sony DSC F707.  Maybe most people with
OHCI controllers haven't had problems, but if so they've been quietly
satisfied.

-- 
Barney Wolff         http://www.databus.com/bwresume.pdf
I'm available by contract or FT, in the NYC metro area or via the 'Net.