Date: Sun, 9 Jul 2023 15:02:09 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: Juraj Lutter <otis@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4e184db51f52 - main - textproc/kibana8: Update to 8.8.2 Message-ID: <CAFDf7UJMHzeeRxRF=9GgOvnsCapk2H1fbbjjkt35vHuLdHCA=g@mail.gmail.com> In-Reply-To: <CAMHz58TnLEWg36yJWgfbNOKoqqXEY3ktMpJ1tO0qwwhVrLFtTQ@mail.gmail.com> References: <202307091255.369CtMsX004111@gitrepo.freebsd.org> <CAMHz58TnLEWg36yJWgfbNOKoqqXEY3ktMpJ1tO0qwwhVrLFtTQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000089cd5406000e50b8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, That's a good example to try to understand why some ports use ${LOCALBASE}/bin/file:<cat>/<port> instead of: <port>:<cat>/<port> since we have much better control on correct version to use like above: npm-node16*>=3D9.7.2*:www/npm-node16 Po-Chuan Hsieh <sunpoet@freebsd.org> escreveu no dia domingo, 9/07/2023 =C3=A0(s) 14:38: > On Sun, Jul 9, 2023 at 8:55=E2=80=AFPM Juraj Lutter <otis@freebsd.org> wr= ote: > >> The branch main has been updated by otis: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D4e184db51f5213b96a3fa2e85311= 1b3d76e75928 >> >> commit 4e184db51f5213b96a3fa2e853111b3d76e75928 >> Author: Juraj Lutter <otis@FreeBSD.org> >> AuthorDate: 2023-07-03 14:18:10 +0000 >> Commit: Juraj Lutter <otis@FreeBSD.org> >> CommitDate: 2023-07-09 12:55:00 +0000 >> >> textproc/kibana8: Update to 8.8.2 >> >> - Update to 8.8.2 >> - Regen patches >> >> Release notes: >> https://www.elastic.co/guide/en/kibana/8.8/release-notes-8.8.2.html >> --- >> @@ -80,14 +84,15 @@ do-configure: >> "! ( -name \.* -or -path *\/test\/* -or -name test )") >> (cd ${_RE2DIR} && \ >> ${SETENV} HOME=3D${WRKDIR} \ >> - >> ${LOCALBASE}/lib/node_modules/npm/bin/node-gyp-bin/node-gyp configure \ >> + >> ${LOCALBASE}/lib/node_modules/npm/node_modules/.bin/node-gyp configure = \ >> > > Would you like to update BUILD_DEPENDS to ensure that the correct npm > version (9.7.2+) is used? > It also applies to textproc/kibana7. > Thanks. > > -BUILD_DEPENDS=3D ${LOCALBASE}/bin/npm:www/npm-node16 > +BUILD_DEPENDS=3D npm-node16>=3D9.7.2:www/npm-node16 > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000089cd5406000e50b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello,</div><div><br></div><div>That's a good exa= mple to try to understand why some ports use=C2=A0</div><div>${LOCALBASE}/b= in/file:<cat>/<port></div><div>instead of:</div><div><port&g= t;:<cat>/<port></div><div>since we have much better control on = correct version to use like above:<br></div><div>npm-node16<b>>=3D9.7.2<= /b>:www/npm-node16</div></div><br><div class=3D"gmail_quote"><div dir=3D"lt= r" class=3D"gmail_attr">Po-Chuan Hsieh <<a href=3D"mailto:sunpoet@freebs= d.org">sunpoet@freebsd.org</a>> escreveu no dia domingo, 9/07/2023 =C3= =A0(s) 14:38:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><d= iv dir=3D"ltr"><div dir=3D"ltr">On Sun, Jul 9, 2023 at 8:55=E2=80=AFPM Jura= j Lutter <<a href=3D"mailto:otis@freebsd.org" target=3D"_blank">otis@fre= ebsd.org</a>> wrote:<br></div><div class=3D"gmail_quote"><blockquote cla= ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex">The branch main has been updated by otis= :<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D4e184db51f5213b= 96a3fa2e853111b3d76e75928" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3D4e184db51f5213b96a3fa2e853111b3d76e75928</= a><br> <br> commit 4e184db51f5213b96a3fa2e853111b3d76e75928<br> Author:=C2=A0 =C2=A0 =C2=A0Juraj Lutter <otis@FreeBSD.org><br> AuthorDate: 2023-07-03 14:18:10 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Juraj Lutter <otis@FreeBSD.org><br> CommitDate: 2023-07-09 12:55:00 +0000<br> <br> =C2=A0 =C2=A0 textproc/kibana8: Update to 8.8.2<br> <br> =C2=A0 =C2=A0 - Update to 8.8.2<br> =C2=A0 =C2=A0 - Regen patches<br> <br> =C2=A0 =C2=A0 Release notes:<br> =C2=A0 =C2=A0 <a href=3D"https://www.elastic.co/guide/en/kibana/8.8/release= -notes-8.8.2.html" rel=3D"noreferrer" target=3D"_blank">https://www.elastic= .co/guide/en/kibana/8.8/release-notes-8.8.2.html</a><br> ---<br> @@ -80,14 +84,15 @@ do-configure:<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "! ( -name \.*= -or -path *\/test\/* -or -name test )")<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 (cd ${_RE2DIR} && \<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${SETENV} HOME=3D${= WRKDIR} \<br> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${LOCALBASE}/lib/no= de_modules/npm/bin/node-gyp-bin/node-gyp configure \<br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${LOCALBASE}/lib/no= de_modules/npm/node_modules/.bin/node-gyp configure \<br></blockquote><div>= <br></div><div>Would you like to update BUILD_DEPENDS to ensure that the co= rrect npm version (9.7.2+) is used?</div><div>It also applies to textproc/k= ibana7.</div><div>Thanks.</div><div><br></div>-BUILD_DEPENDS=3D =C2=A0 =C2= =A0 ${LOCALBASE}/bin/npm:www/npm-node16<br><div>+BUILD_DEPENDS=3D =C2=A0 = =C2=A0 =C2=A0 npm-node16>=3D9.7.2:www/npm-node16</div></div></div> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ= er (ports)</span></div></div> --00000000000089cd5406000e50b8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJMHzeeRxRF=9GgOvnsCapk2H1fbbjjkt35vHuLdHCA=g>