Date: Tue, 11 Mar 2014 02:17:23 GMT From: Kan Sasaki <sasaki@fcc.ad.jp> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/187434: [patch] devel/git: git does not compile when ICONV option selected Message-ID: <201403110217.s2B2HNpv085083@cgiserv.freebsd.org> Resent-Message-ID: <201403110220.s2B2K01t041207@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 187434
>Category: ports
>Synopsis: [patch] devel/git: git does not compile when ICONV option selected
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 11 02:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Kan Sasaki
>Release: FreeBSD 10.0-STABLE amd64
>Organization:
>Environment:
>Description:
NEEDS_LIBICONV is still needed when ICONV option is selected. It was removed by r347294.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 347825)
+++ Makefile (working copy)
@@ -83,6 +83,7 @@
.if ${PORT_OPTIONS:MICONV}
USES+= iconv
+MAKE_ARGS+= NEEDS_LIBICONV=1
.else
MAKE_ARGS+= NO_ICONV=1
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403110217.s2B2HNpv085083>