Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Apr 2019 20:07:12 -0700
From:      Enji Cooper <yaneurabeya@gmail.com>
To:        Phil Shafer <phil@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-vendor@freebsd.org
Subject:   Re: svn commit: r345860 - vendor/Juniper/libxo
Message-ID:  <D083E2F3-E779-484A-A6D9-F4F4D8425A18@gmail.com>
In-Reply-To: <201904032230.x33MUKRn029430@repo.freebsd.org>
References:  <201904032230.x33MUKRn029430@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On Apr 3, 2019, at 3:30 PM, Phil Shafer <phil@FreeBSD.org> wrote:
>=20
> Author: phil
> Date: Wed Apr  3 22:30:20 2019
> New Revision: 345860
> URL: https://svnweb.freebsd.org/changeset/base/345860
>=20
> Log:
>  Add "MAKE=3Dgmake" to "configure" invocations in libxo import script
>=20
> Modified:
>  vendor/Juniper/libxo/import.sh
>=20
> Modified: vendor/Juniper/libxo/import.sh
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- vendor/Juniper/libxo/import.sh	Wed Apr  3 21:55:39 2019	=
(r345859)
> +++ vendor/Juniper/libxo/import.sh	Wed Apr  3 22:30:20 2019	=
(r345860)
> @@ -280,12 +280,12 @@ Cd $CWD/dist
> run "autoreconf" "autoreconf --install --force"
>=20
> Cd $CWD/dist/build
> -run "configure for testing" "../configure --prefix =
$CWD/dist/build/root"
> +run "configure for testing" "env MAKE=3Dgmake ../configure --prefix =
$CWD/dist/build/root"
> run "build and test" \
>         "${GMAKE} clean && ${GMAKE} && ${GMAKE} install && ${GMAKE} =
test"
>=20
> # Freebsd lacks stock gettext, so don't build it
> -run "configure for real" "../configure --disable-gettext --prefix =
/usr"
> +run "configure for real" "env MAKE=3Dgmake ../configure =
--disable-gettext --prefix /usr"
> run "build for real" \
>         "${GMAKE} clean && ${GMAKE}=E2=80=9D

I could be wrong, but I=E2=80=99m guessing `GMAKE` needs to be replaced =
with `MAKE`..?

Also, why does a configure script need gmake? It seems like the snippets =
that make libxo should be made more portable with autoconf, if that=E2=80=99=
s the case.

Thanks,
-Enji=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D083E2F3-E779-484A-A6D9-F4F4D8425A18>