From owner-p4-projects@FreeBSD.ORG  Sun Dec 30 00:48:25 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C89ED16A418; Sun, 30 Dec 2007 00:48:25 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E70F16A421
	for <perforce@FreeBSD.org>; Sun, 30 Dec 2007 00:48:25 +0000 (UTC)
	(envelope-from gcooper@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D07213C465
	for <perforce@FreeBSD.org>; Sun, 30 Dec 2007 00:48:25 +0000 (UTC)
	(envelope-from gcooper@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBU0mPuh028733
	for <perforce@FreeBSD.org>; Sun, 30 Dec 2007 00:48:25 GMT
	(envelope-from gcooper@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBU0mPAo028730
	for perforce@freebsd.org; Sun, 30 Dec 2007 00:48:25 GMT
	(envelope-from gcooper@FreeBSD.org)
Date: Sun, 30 Dec 2007 00:48:25 GMT
Message-Id: <200712300048.lBU0mPAo028730@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gcooper@FreeBSD.org using -f
From: Garrett Cooper <gcooper@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 132000 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Dec 2007 00:48:26 -0000

http://perforce.freebsd.org/chv.cgi?CH=132000

Change 132000 by gcooper@shiina-ibook on 2007/12/30 00:47:46

	- pkg_action_null's a noop function. So why does it have to be interactive?
	- Trim down the __unused's..

Affected files ...

.. //depot/projects/soc2007/revised_fbsd_pkgtools/pkg_revised/v2/contrib/libpkg/pkg_db.c#5 edit

Differences ...

==== //depot/projects/soc2007/revised_fbsd_pkgtools/pkg_revised/v2/contrib/libpkg/pkg_db.c#5 (text+ko) ====

@@ -107,17 +107,12 @@
 
 /**
  * @brief The package action used when no output is required
- * Andrew:
- * 	@todo Change to follow the interactive flag
- * Garrett:
- * 	This isn't necessary I think, and should stick with
- * 	the interface, not with the library.
  * 
  * This is a function that does nothing.
  * It can be used for a pkg_action when no output is required
  */
 void
-pkg_action_null(enum pkg_action_level level __unused, const char *fmt __unused,
+pkg_action_null(enum pkg_action_level level, const char *fmt,
     ...)
 {
 }
@@ -313,7 +308,7 @@
  * @return 0
  */
 int
-pkg_match_all(struct pkg *pkg __unused, const void *data __unused)
+pkg_match_all(struct pkg *pkg, const void *data)
 {
     return 0;
 }