From owner-svn-src-all@FreeBSD.ORG Mon Nov 8 01:54:42 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2418106566B; Mon, 8 Nov 2010 01:54:42 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 80ABF8FC0C; Mon, 8 Nov 2010 01:54:42 +0000 (UTC) Received: by gxk9 with SMTP id 9so3213380gxk.13 for ; Sun, 07 Nov 2010 17:54:41 -0800 (PST) Received: by 10.151.14.7 with SMTP id r7mr7636842ybi.19.1289181280906; Sun, 07 Nov 2010 17:54:40 -0800 (PST) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.236.110.35 with HTTP; Sun, 7 Nov 2010 17:54:20 -0800 (PST) In-Reply-To: <201011072322.oA7NMhb0092364@svn.freebsd.org> References: <201011072322.oA7NMhb0092364@svn.freebsd.org> From: Juli Mallett Date: Sun, 7 Nov 2010 17:54:20 -0800 X-Google-Sender-Auth: 7xRZQ-cdP9xuEOJjnnbKbrERI44 Message-ID: To: "David E. O'Brien" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214961 - head/usr.bin/yacc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2010 01:54:43 -0000 David, On Sun, Nov 7, 2010 at 15:22, David E. O'Brien wrote: > Author: obrien > Date: Sun Nov =A07 23:22:42 2010 > New Revision: 214961 > URL: http://svn.freebsd.org/changeset/base/214961 > > Log: > =A0Directly use memory allocation functions and remove needless casts in > =A0their usage. =A0Also use associated modern types instead of k&r ones. You do know that changing skeleton.c affects the generated files, right? I'm wondering if whatever sed script you're judiciously-applying knows that. C++ does not do implicit conversions from "void *" so you need the casts on the mallocs there. With a C++ compiler: y.tab.c:116: error: invalid conversion from 'void*' to 'short int*' y.tab.c:122: error: invalid conversion from 'void*' to 'YYSTYPE*' Please back out the changes to the skeleton.