Date: Fri, 12 Apr 2002 19:43:46 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Mike Barcroft <mike@FreeBSD.ORG> Cc: current@FreeBSD.ORG, "David O'Brien" <obrien@FreeBSD.ORG> Subject: Re: alpha tinderbox failure Message-ID: <20020412164346.GE56075@sunbay.com> In-Reply-To: <20020412121212.E28249@espresso.q9media.com> References: <200204111654.g3BGsmc9069057@beast.freebsd.org> <20020412135421.GC27751@sunbay.com> <20020412121212.E28249@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--KuLpqunXa7jZSBt+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Apr 12, 2002 at 12:12:12PM -0400, Mike Barcroft wrote:
> Ruslan Ermilov <ru@FreeBSD.ORG> writes:
> > I see the same breakage here.
> >=20
> > The breakage has nothing to do with -Werror. Recent commit by
> > Mike Barcroft to sys/*/endian.h is the culprit.
> >=20
> > But the actual problem is with gdb. After a lot of experimenting
> > I've found that contrib/gdb.291/gdb/defs.h includes "nm.h"
> > (gnu/usr.bin/binutils/gdb/${MACHINE_ARCH}/nm.h) which are too
> > different between i386 and alpha. In the i386 case, "nm.h"
> > includes <sys/types.h> which exposes __BSD_VISIBLE (see how
> > these affect the *_ENDIAN macros in sys/*/endian.h). But not
> > in the alpha case. Applying this patch exposes the same bug
> > on i386:
> >
> [...]
>=20
> David added <sys/types.h> to src/gnu/usr.bin/binutils/gdb/alpha/nm.h=20
> 19 hours ago, so the problem should no longer exist. I won't know for
> another three hours (when my alpha is finished buildworld).
>=20
Heh, while I started looking at it, there was no this commit message
in my mailbox yet. :-)
I'm sure you realize that this commit fixed the breakage as a
side effect, and now the defs.h bug is hidden the same way as
for i386.
> > The solution is to fix defs.h:
> >=20
> > %%%
> > Index: defs.h
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /home/ncvs/src/contrib/gdb.291/gdb/defs.h,v
> > retrieving revision 1.3
> > diff -u -p -r1.3 defs.h
> > --- defs.h 11 Apr 2001 16:15:19 -0000 1.3
> > +++ defs.h 12 Apr 2002 13:53:37 -0000
> > @@ -841,6 +841,8 @@ extern void free ();
> > =20
> > #ifdef HAVE_ENDIAN_H
> > #include <endian.h>
> > +#else
> > +#include <sys/types.h>
> > #endif
> > =20
> > #if !defined (BIG_ENDIAN)
> > %%%
>=20
> I think <machine/endian.h> would be better here. It may not have
> worked because of the missing <sys/cdefs.h> issue.
>=20
Yes, definitely this is better, now that you've fixed endian.h's.
The optimal solution IMO is to introduce HAVE_MACHINE_ENDIAN_N.
<endian.h> is pretty non-standard.
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
--KuLpqunXa7jZSBt+
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE8tw7BUkv4P6juNwoRArn0AJ0e/DnsbbrWmvgyE4ty4L1jLK4NYwCcC38T
b+hpg5Es0yGYoGO+mXMDn9c=
=KvJw
-----END PGP SIGNATURE-----
--KuLpqunXa7jZSBt+--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020412164346.GE56075>