From owner-freebsd-current@FreeBSD.ORG Sat Jul 21 20:00:51 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEA201065674; Sat, 21 Jul 2012 20:00:51 +0000 (UTC) (envelope-from w8hdkim@gmail.com) Received: from mail-qc0-f182.google.com (mail-qc0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 882038FC19; Sat, 21 Jul 2012 20:00:51 +0000 (UTC) Received: by qcsg15 with SMTP id g15so3306634qcs.13 for ; Sat, 21 Jul 2012 13:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4Iv3C61RU0o5ZY4WvN4TLpromo3ucFoO/bQHc0UmJZw=; b=wGUMzKfRUD1fyqO9oEgoDM6ZDh5eTIcMf6iKOIdgdGdTU6OCB82R0wYlUlvDOF29kP OcHj4G3SKoMib6uBqUOjCOCzCWUeh2azhYj0EMLrnXUFzuKzqNdo+Js/2KYWx9LLKqUP EPVxIAmUvf1jItWyw+ZL2yrfQL50/mEWLxlvyFrAhM5FBJQqpaEDmSh1JDDPQ6ZGZjVu MgCc+iO78tg9l8GjHVSoIV7G/gxwDJ8DZ+FapXUVUqDjjdjb9FOgA35X8lG4Px4fFPcV U56Vg31b+uXWck4GwcPpsataUhZPwQm1cS7oqwlNkS4Tv6R7cEQAQdTqzymDXbgtIgZl TEzw== MIME-Version: 1.0 Received: by 10.224.175.8 with SMTP id v8mr16855725qaz.47.1342900845275; Sat, 21 Jul 2012 13:00:45 -0700 (PDT) Received: by 10.229.39.12 with HTTP; Sat, 21 Jul 2012 13:00:45 -0700 (PDT) In-Reply-To: <50097BF0.9010103@FreeBSD.org> References: <50097BF0.9010103@FreeBSD.org> Date: Sat, 21 Jul 2012 16:00:45 -0400 Message-ID: From: Kim Culhan To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org Subject: Re: -current build failure X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2012 20:00:51 -0000 On Fri, Jul 20, 2012 at 11:40 AM, Dimitry Andric wrote: > On 2012-07-20 16:49, Kim Culhan wrote: >> Seeing this for r:238655 > ... >> In file included from /usr/src/sys/modules/dtrace/dtrace/../../../sys/pcpu.h:44: >> ./machine/pcpu.h:226:13: error: indirection of non-volatile null >> pointer will be deleted, not trap >> [-Werror,-Wnull-dereference] >> : "m" (*(char *)OFFSETOF_CURTHREAD)); >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> ./machine/pcpu.h:226:13: note: consider using __builtin_trap() or >> qualifying pointer with 'volatile' > > That's indeed a valid warning from clang, since OFFSETOF_CURTHREAD is > usually zero. It's probably due to recent work on dtrace. I'm not in > the neighborhood of a FreeBSD box right now to verify, but can you > please try to change the cast to "(volatile char *)"? That should fix > the warning. Yes it did, I know there are many considerations wrt to this warning. thanks -kim