From owner-cvs-src@FreeBSD.ORG  Wed Jun 21 17:28:53 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B804616A474;
	Wed, 21 Jun 2006 17:28:53 +0000 (UTC)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A1D3F43D6B;
	Wed, 21 Jun 2006 17:28:50 +0000 (GMT)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: from hydrogen.funkthat.com (p5itay6smysr9k2v@localhost.funkthat.com
	[127.0.0.1])
	by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id k5LHSovK083768; 
	Wed, 21 Jun 2006 10:28:50 -0700 (PDT)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (from jmg@localhost)
	by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id k5LHSoZH083767;
	Wed, 21 Jun 2006 10:28:50 -0700 (PDT) (envelope-from jmg)
Date: Wed, 21 Jun 2006 10:28:49 -0700
From: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
To: Konstantin Belousov <kib@FreeBSD.org>
Message-ID: <20060621172849.GA82074@funkthat.com>
References: <200606211259.k5LCx5as082227@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200606211259.k5LCx5as082227@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386
X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31  96 7A 22 B3 D8 56 36 F4
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/sys mincore.2 src/sys/vm vm_mmap.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2006 17:28:53 -0000

Konstantin Belousov wrote this message on Wed, Jun 21, 2006 at 12:59 +0000:
>   Modified files:
>     lib/libc/sys         mincore.2 
>     sys/vm               vm_mmap.c 
>   Log:
>   Make the mincore(2) return ENOMEM when requested range is not fully mapped.

Is this change to be posix compliant or something?  ENOMEM seems like
the wrong error, or are we allocating memory?
#define ENOMEM          12              /* Cannot allocate memory */

the original EINVAL seems to me the correct one, as is commonly used
when the data passed in is incorrect...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."