From nobody Wed Jan 29 02:55:12 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjRbN2rYkz5ldgK; Wed, 29 Jan 2025 02:55:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjRbN2DvGz3wRT; Wed, 29 Jan 2025 02:55:12 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738119312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WedJBrUYZ9CkdlEI7/CYZgPGvzr2uH9XLrddH8h5fnk=; b=CYvJ0Vaz9L4YQt9Kfu/GoZttVCLpIm6piQKXUCg7LA4yydUTOe0bEx88/evtMEyhi+dHqc 3MsBabBxACpnwxkNx3DJwvEuaXR+iEDtSI+JLM4+JniOSRZ3aAFLAu6QL9Rru5WjnVuw5e 4Jpp46vc2peId1Z2XRVr9aqCL/ZL2s4NbQRobUoYgZ9fVeugvTiTHfJxy+ZA6dKGWjdDRF DUC4fqIWENBHsRgSCSfY+KJToSjuppwoR4zGBqYvX/jtv590Jte8ZUe7n43rcRE3E5nPGW Bt8nV9OW4qvOzO5Rjl6aCOE1SjS8IqgASumgLq4eDkBJQLyLGKXyhIvom8XUfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738119312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WedJBrUYZ9CkdlEI7/CYZgPGvzr2uH9XLrddH8h5fnk=; b=fBdEj7FTZOTAo1WrilDOI2MoW99DqCJAhcMFOyEIsClBnPCn6FJ3dGUo4VnZVemTOxvNrb Gz/3BjqabmKvvYtQ2Md8F5FRxMr+pBPM2tvwgEzQJC7PRMw7uMQ4U+niYmYQqTw2pCwKfm cSvEin7jK/sZb9s7O/dqoLviu+TRLxqHwZNNNMTuYaFzyq0Z3Yz8r950oQZ0ovZR+WonA9 TqyBMp3hbdltwSMUnXpsS5I5vOpkSF0D+sfgwa8OCN0xlbYb6U50ViaCt8/XJcPz3Edb0s 4LV6bvk6gzm3ekeTLjzuzZlQDV6YbFtnnZz5Yy1P6lYNAv7gds7G8vKidPf1Jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738119312; a=rsa-sha256; cv=none; b=ALSyK/Yog5zZwJRBV0giw7fPS0RjMEYJU3YgFN1JnpYGQ0ivep4f6i3/Q8Sq8ED+mKzDdz PXtVtySk6j6S2qgYTXkW5YJCha/9sjgXIco/VVnyqNS3XH2HsS2idRnRFwuNpN0pDNxWQB PIbq35y/S3fc2KyviPGaSAzw77Cw/0SZIQbiZuoikKOLYgnacVMB3gbn+IeqJFewmV76tP iY1jGfdzNbQKN3Y5V2qDRJcFrSHbW7ydVLXF12e9pZiMYDRdTickFzp5nSP4lLChyoy0uG 7yvK4n8oyQ4buwvfqRrlmlEFcZMi6cqYPfcdlA1enXB2OBbA8TI3ZjtHMyggxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1033) id 255011DEB0; Wed, 29 Jan 2025 02:55:12 +0000 (UTC) Date: Wed, 29 Jan 2025 02:55:12 +0000 From: Alexey Dokuchaev To: Dimitry Andric Cc: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: c3450ad127e9 - main - clang: re-downgrade implicit int/function declarations to warning only Message-ID: References: <202306222111.35MLBAqB066211@gitrepo.freebsd.org> <90D8C9F1-0634-44E5-B5B5-20455A91E042@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90D8C9F1-0634-44E5-B5B5-20455A91E042@FreeBSD.org> On Wed, Jan 29, 2025 at 12:20:51AM +0100, Dimitry Andric wrote: > On 28 Jan 2025, at 19:32, Jessica Clarke wrote: > > On 22 Jun 2023, at 22:11, Dimitry Andric wrote: > >> > >> clang: re-downgrade implicit int/function declarations to warning only > >> > >> [...] > >> As noted in the upstream discussion, there are many programs that fail > >> to configure or build correctly, if these warnings are turned into > >> errors by default. > >> > >> Note that most affected programs in ports are relatively old, and are > >> unlikely to be fixed by actually adjusting their declarations, but by > >> compiling with -std=gnu89, which downgrades the errors back to warning > >> again. Lots of tedious work for very little gain. > > > > This remains as a downstream divergence 1.5 years later, but I do not > > think we should be carrying this indefinitely. Software needs to build > > with upstream LLVM, and the fact that many ports do not is now biting > > us for CheriBSD where we use our own external toolchain that does not > > have such a diff. In my opinion this should be reverted for FreeBSD 15 > > and it's long time for ports people to step up or have the broken ports > > removed; we can't keep going on like this with abandonware holding back > > forward progress. > > While I agree, at the least a full exp-run should be done, and even then > you can't be entirely sure if ports that build are built the same as > before, for example due to bad configure tests. So this is potentially a > massive undertaking. Can we actually do an exp-run to identify affected ports and at least get the idea of the fallout size? I've recently hunted one such subtle bug exposed by GCC 14 so yeah I fear there'd be a lot, but we need to start with something. I presume fixing it won't be particularly hard, just tedious. ./danfe