From owner-svn-src-head@freebsd.org  Thu Jun 16 18:15:11 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ACB8A776CD
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Thu, 16 Jun 2016 18:15:11 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7A4B822B0
 for <svn-src-head@freebsd.org>; Thu, 16 Jun 2016 18:15:11 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 4dc9bd32-33ee-11e6-8929-8ded99d5e9d7
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.34.117.227
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Thu, 16 Jun 2016 18:15:27 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.14.9) with ESMTP id u5GIF3vH005643;
 Thu, 16 Jun 2016 12:15:03 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1466100903.51702.5.camel@freebsd.org>
Subject: Re: svn commit: r301959 - head/sys/kern
From: Ian Lepore <ian@freebsd.org>
To: Ngie Cooper <yaneurabeya@gmail.com>, cem@freebsd.org
Cc: Konstantin Belousov <kib@freebsd.org>, src-committers
 <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Thu, 16 Jun 2016 12:15:03 -0600
In-Reply-To: <E27E4A0B-949C-4DCA-A9D4-B3B822E13C18@gmail.com>
References: <201606161158.u5GBwkd1042632@repo.freebsd.org>
 <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com>
 <E27E4A0B-949C-4DCA-A9D4-B3B822E13C18@gmail.com>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2016 18:15:11 -0000

On Thu, 2016-06-16 at 10:43 -0700, Ngie Cooper wrote:
> > On Jun 16, 2016, at 10:17, Conrad Meyer <cem@freebsd.org> wrote:
> > 
> > > On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov <
> > > kib@freebsd.org> wrote:
> > > --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016       
> > >  (r301958)
> > > +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016       
> > >  (r301959)
> > > @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2,
> > >                        wakeup_swapper |= sleepq_abort(td2,
> > > EINTR);
> > >                break;
> > >        case SINGLE_BOUNDARY:
> > > -               if (TD_IS_SUSPENDED(td2) && (td2->td_flags &
> > > TDF_BOUNDARY) == 0)
> > > -                       wakeup_swapper |=
> > > thread_unsuspend_one(td2, p, false);
> > > -               if (TD_ON_SLEEPQ(td2) && (td2->td_flags &
> > > TDF_SINTR) != 0)
> > > -                       wakeup_swapper |= sleepq_abort(td2,
> > > ERESTART);
> > > -               break;
> > 
> > style(9) nit: /* FALLTHROUGH */
> > 
> Also, coverity will complain about the missing break unless that's
> there...
> 

If coverity complains about

  case 1:
  case 2:
    statements;
    break;

then it is coverity that needs to be fixed.

-- Ian

> > Best,
> > Conrad
> > 
> > >        case SINGLE_NO_EXIT:
> > >                if (TD_IS_SUSPENDED(td2) && (td2->td_flags &
> > > TDF_BOUNDARY) == 0)
> > >                        wakeup_swapper |=
> > > thread_unsuspend_one(td2, p, false);
> > 
> 
>