From owner-cvs-src@FreeBSD.ORG Thu Nov 22 23:32:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C3E116A468 for ; Thu, 22 Nov 2007 23:32:24 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id EED8913C4D3 for ; Thu, 22 Nov 2007 23:32:23 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 47604 invoked from network); 22 Nov 2007 23:32:11 -0000 Received: from ppp-71-139-1-224.dsl.snfc21.pacbell.net (HELO ?10.0.5.18?) (nate-mail@71.139.1.224) by root.org with ESMTPA; 22 Nov 2007 23:32:11 -0000 Message-ID: <47461174.2060104@root.org> Date: Thu, 22 Nov 2007 15:32:04 -0800 From: Nate Lawson User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Maxim Sobolev References: <200711212115.lALLF16n017990@repoman.freebsd.org> <4744DE58.9090005@FreeBSD.org> <4744EF09.4060009@FreeBSD.org> <474533A4.3030106@deepcore.dk> <20071122082847.N60495@fledge.watson.org> <4746075D.9000108@FreeBSD.org> In-Reply-To: <4746075D.9000108@FreeBSD.org> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org, =?ISO-8859-1?Q?S=F8ren_Schmidt?= Subject: Re: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-pci.c ata-pci.h atapi-cd.c atapi-fd.c atapi-tape.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2007 23:32:24 -0000 Maxim Sobolev wrote: > Robert Watson wrote: >> On Thu, 22 Nov 2007, Søren Schmidt wrote: >> >>>>>> FreeBSD src repository >>>>>> >>>>>> Modified files: (Branch: RELENG_7) >>>>>> sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-pci.c >>>>>> ata-pci.h atapi-cd.c atapi-fd.c atapi-tape.c Log: >>>>>> Update with the latest fixes from -current. >>>>> >>>>> Please don't forget to merge at least atapi-cd.c fix into RELENG_6. >>>>> Currently CD is not working in Parallels with 6.3-PRERELEASE. >>>> >>>> Also, I see some "ad0: TIMEOUT - WRITE_DMA (retrying)" messages with >>>> Parallels using latest 6.3-PRERELEASE snapshot. Not sure if it's due >>>> to some changes between 6.2 and 6.3, but I've never seen this with >>>> 6.2. Any ideas? >>> >>> I have a complete backport of all the latest fixes done for 6.3 >>> awaiting approval. >>> >>> I've seen such a timeout once on 6.3 before I merged the latest >>> changes, since then I've not seen any, not that it means much though :) >> >> I see them any time I do anything involving significant disk load >> under Parallels--I've always assumed it was because there are several >> layers of indirection, including HFS+ and an expanding Parallels disk >> image, beween the FreeBSD ATA driver and hardware, leading to >> significantly longer delays than the ATA driver would expect from >> normal hardware. That said, I'm fine with being wrong and seeing a >> bug fixed :-). I usually get several each time I buildkernel, such as >> last night: >> >> ad0: TIMEOUT - READ_DMA retrying (1 retry left) LBA=5208191 >> ad0: TIMEOUT - READ_DMA retrying (1 retry left) LBA=23670111 >> ad0: TIMEOUT - READ_DMA retrying (1 retry left) LBA=5843715 >> ad0: TIMEOUT - WRITE_DMA retrying (1 retry left) LBA=40407615 > > Assuming that there are no actual bugs in the code, should not it make > sense to detect virtual hardware and treat it a little bit differently > with respect to timeouts? Given the growing popularity of virtualization > technology it's doesn't sound like a worthless project. Last time I looked at the ata code, I found the timeout was much too low for common drives (non-virtual). Anything that took a little longer to spin up from idle or under heavy shared irq load would time out and retry. I think I bumped it up to 30 seconds and kept retry count at 5. -- Nate