From owner-svn-src-head@FreeBSD.ORG  Tue Sep 21 15:40:52 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 12E501065673;
	Tue, 21 Sep 2010 15:40:51 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 114308FC1B;
	Tue, 21 Sep 2010 15:40:49 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA09398;
	Tue, 21 Sep 2010 18:40:48 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Message-ID: <4C98D200.4040909@freebsd.org>
Date: Tue, 21 Sep 2010 18:40:48 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.9) Gecko/20100920 Lightning/1.0b2 Thunderbird/3.1.4
MIME-Version: 1.0
To: mdf@freebsd.org
References: <201009211507.o8LF7iVv097676@svn.freebsd.org>
	<AANLkTi=CTr+ZDs3znsF-SXDp__xxbetjnhSBxiDhfFYy@mail.gmail.com>
	<4C98CEE7.6060802@freebsd.org>
In-Reply-To: <4C98CEE7.6060802@freebsd.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212964 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Sep 2010 15:40:52 -0000

on 21/09/2010 18:27 Andriy Gapon said the following:
> on 21/09/2010 18:17 mdf@FreeBSD.org said the following:
>>
>> I'd recommend using stack_print_ddb(), as that avoids any locking
>> which may hang depending on how the kernel panic'd.
> 
> It seems that stack_print_ddb() depends on DDB?

But the point about locking is very good.
How do you suggest we can deal with it?

A dirty hack would be to check panicstr in linker_search_symbol_name and avoid
locking, but I don't like that at all.
Perhaps, some code in subr_stack.c could be taken outside DDB ifdef?

Thank you!
-- 
Andriy Gapon