From owner-p4-projects@FreeBSD.ORG Tue Jul 31 04:47:34 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A495116A418; Tue, 31 Jul 2007 04:47:34 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C49416A420 for ; Tue, 31 Jul 2007 04:47:34 +0000 (UTC) (envelope-from loafier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5F90113C494 for ; Tue, 31 Jul 2007 04:47:34 +0000 (UTC) (envelope-from loafier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l6V4lY3K064419 for ; Tue, 31 Jul 2007 04:47:34 GMT (envelope-from loafier@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l6V4lY69064416 for perforce@freebsd.org; Tue, 31 Jul 2007 04:47:34 GMT (envelope-from loafier@FreeBSD.org) Date: Tue, 31 Jul 2007 04:47:34 GMT Message-Id: <200707310447.l6V4lY69064416@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to loafier@FreeBSD.org using -f From: Christopher Davis To: Perforce Change Reviews Cc: Subject: PERFORCE change 124401 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2007 04:47:34 -0000 http://perforce.freebsd.org/chv.cgi?CH=124401 Change 124401 by loafier@chrisdsoc on 2007/07/31 04:46:39 Minor changes to write macros. Affected files ... .. //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac.c#2 edit .. //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac_private.h#2 edit Differences ... ==== //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac.c#2 (text+ko) ==== @@ -1477,8 +1477,6 @@ "%s: Unable to allocate memory resource\n", __func__); return (ENOMEM); } - mem->mem_tag = rman_get_bustag(mem->mem_res); - mem->mem_handle = rman_get_bushandle(mem->mem_res); return (0); } ==== //depot/projects/soc2007/loafier_busalloc/src/sys/dev/sound/pci/hda/hdac_private.h#2 (text+ko) ==== @@ -42,17 +42,17 @@ * Helper Macros ****************************************************************************/ #define HDAC_READ_1(mem, offset) \ - bus_space_read_1((mem)->mem_tag, (mem)->mem_handle, (offset)) + bus_read_1((mem)->mem_res, (offset)) #define HDAC_READ_2(mem, offset) \ - bus_space_read_2((mem)->mem_tag, (mem)->mem_handle, (offset)) + bus_read_2((mem)->mem_res, (offset)) #define HDAC_READ_4(mem, offset) \ - bus_space_read_4((mem)->mem_tag, (mem)->mem_handle, (offset)) + bus_read_4((mem)->mem_res, (offset)) #define HDAC_WRITE_1(mem, offset, value) \ - bus_space_write_1((mem)->mem_tag, (mem)->mem_handle, (offset), (value)) + bus_write_1((mem)->mem_res, (offset), (value)) #define HDAC_WRITE_2(mem, offset, value) \ - bus_space_write_2((mem)->mem_tag, (mem)->mem_handle, (offset), (value)) + bus_write_2((mem)->mem_res, (offset), (value)) #define HDAC_WRITE_4(mem, offset, value) \ - bus_space_write_4((mem)->mem_tag, (mem)->mem_handle, (offset), (value)) + bus_write_4((mem)->mem_res, (offset), (value)) #define HDAC_ISDCTL(sc, n) (_HDAC_ISDCTL((n), (sc)->num_iss, (sc)->num_oss)) #define HDAC_ISDSTS(sc, n) (_HDAC_ISDSTS((n), (sc)->num_iss, (sc)->num_oss)) @@ -97,8 +97,6 @@ struct hdac_mem { struct resource *mem_res; int mem_rid; - bus_space_tag_t mem_tag; - bus_space_handle_t mem_handle; }; /****************************************************************************