From owner-svn-src-all@freebsd.org  Mon Sep 21 23:04:56 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5BBE79D07D4;
 Mon, 21 Sep 2015 23:04:56 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C82E415C9;
 Mon, 21 Sep 2015 23:04:55 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t8LN4oaF077521
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Tue, 22 Sep 2015 02:04:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t8LN4oaF077521
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t8LN4oLw077520;
 Tue, 22 Sep 2015 02:04:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 22 Sep 2015 02:04:50 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r287934 - head/sys/boot/efi/loader
Message-ID: <20150921230450.GB67105@kib.kiev.ua>
References: <13e1fdb2-6e22-4371-95e4-a556c357fa8d@me.com>
 <CAJ-Vmok6+2vcekUZLU0uRSGqQtgNqmBQBu82sOiSMR_BPy0U2w@mail.gmail.com>
 <7425989.fyHR6C7Hof@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7425989.fyHR6C7Hof@ralph.baldwin.cx>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Sep 2015 23:04:56 -0000

On Mon, Sep 21, 2015 at 03:31:11PM -0700, John Baldwin wrote:
> (I'm of the opinion we should inline atomics and locks, etc. in modules
> built as part of a kernel to match that kernel's config and only use shims
> for modules built standalone.  Most of this can probably be accomplished by
> having modules built as part of a kernel not define KLD_MODULE during their
> build but only use that for standalone modules.  However, I haven't audited
> all the uses of KLD_MODULE to see if we might want some of them to be on
> for "bundled" modules in which case we'd need to add a new #define that
> gets defined for "bundled" modules but not standalone modules (or gets
> defined for both?) and fixup the code appropriately.)
At least one use of KLD_MODULE outside the atomics and locks category is
the definition of MAKEDEV_ETERNAL_KLD in sys/conf.h.