From owner-svn-src-all@freebsd.org Tue Jul 30 17:24:08 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B6A4A89EA; Tue, 30 Jul 2019 17:24:08 +0000 (UTC) (envelope-from br@bsdpad.com) Received: from sc1.bsdpad.com (sc1.bsdpad.com [163.172.212.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5BF3E6A048; Tue, 30 Jul 2019 17:24:07 +0000 (UTC) (envelope-from br@bsdpad.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bsdpad.com; s=20190317; h=Subject:To:From; bh=YEYx1/+GbbW2mHaPI7lIsXkphO7mV9A+SM9UCoIi17I=; b=EuXYfe+L5lv5KL7BMLrM3x7Pin OXcWfA5hoUSmTA7Bxl+7Sx76vS7ugmARjeBkEHzV0QU6nMs8rAUKF1ouEEJx7neZPr2CaP2rbfjCF WZ7miTemJF6fPFMBU2itLNCylUBTWCHVIAJqdRNbO5en7yGxGGhVfZ9YqNpNnJTOciQ1qS8ytsTOy cQR+26DOP3x8An6waRbyT2sGrCFFObhHrwGuaSaIA1Jg7Ujn8bCmwUZGT2Uvu1Ee97Wi6ZiWoAdVr oOIwkVP7QmQlbchSVeuF8RCZpSz0UBa4T4G/nj4HXKnNfjbtzzA5w9fmwO4uuIc9B8nKOI87Ip5f4 KKCWd6UQ==; Received: from localhost ([127.0.0.1] helo=bsdpad.com) by sc1.bsdpad.com with smtp (Exim 4.91 (FreeBSD)) (envelope-from ) id 1hsVoo-000PVF-Bh; Tue, 30 Jul 2019 18:21:46 +0100 Received: by bsdpad.com (nbSMTP-1.00) for uid 1001 br@bsdpad.com; Tue, 30 Jul 2019 18:21:46 +0100 (BST) Date: Tue, 30 Jul 2019 18:21:46 +0100 From: Ruslan Bukin To: Toomas Soome Cc: Ruslan Bukin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350444 - head/stand/efi/loader Message-ID: <20190730172146.GA97694@bsdpad.com> References: <201907301454.x6UEsIVC045133@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 5BF3E6A048 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdpad.com header.s=20190317 header.b=EuXYfe+L; spf=pass (mx1.freebsd.org: domain of br@bsdpad.com designates 163.172.212.18 as permitted sender) smtp.mailfrom=br@bsdpad.com X-Spamd-Result: default: False [-6.30 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdpad.com:s=20190317]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[bsdpad.com]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdpad.com:+]; MX_GOOD(-0.01)[sc1.bsdpad.com]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; IP_SCORE(-2.83)[ip: (-9.46), ipnet: 163.172.208.0/20(-4.75), asn: 12876(0.08), country: FR(-0.01)]; FREEMAIL_TO(0.00)[me.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:12876, ipnet:163.172.208.0/20, country:FR]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2019 17:24:08 -0000 Hi No, this is linking-stage fix only. efinet.c, efihttp.c are still included to the build I guess we could exclude them from compilation as it makes no sense Ruslan On Tue, Jul 30, 2019 at 07:00:34PM +0300, Toomas Soome wrote: > hi! > > efihttp is also using network, is it intentionally left untouched? > > rgds, > toomas > > > On 30 Jul 2019, at 17:54, Ruslan Bukin wrote: > > > > Author: br > > Date: Tue Jul 30 14:54:18 2019 > > New Revision: 350444 > > URL: https://svnweb.freebsd.org/changeset/base/350444 > > > > Log: > > Fix EFI loader build when LOADER_NET_SUPPORT=no. > > > > Sponsored by: DARPA, AFRL > > > > Modified: > > head/stand/efi/loader/conf.c > > > > Modified: head/stand/efi/loader/conf.c > > ============================================================================== > > --- head/stand/efi/loader/conf.c Tue Jul 30 14:21:00 2019 (r350443) > > +++ head/stand/efi/loader/conf.c Tue Jul 30 14:54:18 2019 (r350444) > > @@ -40,7 +40,9 @@ struct devsw *devsw[] = { > > &efipart_cddev, > > &efipart_hddev, > > &efihttp_dev, /* ordering with efinet_dev matters */ > > +#if defined(LOADER_NET_SUPPORT) > > &efinet_dev, > > +#endif > > &vdisk_dev, > > #ifdef EFI_ZFS_BOOT > > &zfs_dev, > > @@ -64,7 +66,9 @@ struct fs_ops *file_system[] = { > > }; > > > > struct netif_driver *netif_drivers[] = { > > +#if defined(LOADER_NET_SUPPORT) > > &efinetif, > > +#endif > > NULL > > }; > > > > > >