Date: Sun, 15 Jul 2018 10:17:37 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Ian Lepore <ian@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715171737.GA31164@troutmask.apl.washington.edu> In-Reply-To: <1531674041.26036.1.camel@freebsd.org> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote: > On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote: > > Index: ld80/e_powl.c > > =================================================================== > > --- ld80/e_powl.c (revision 336304) > > +++ ld80/e_powl.c (working copy) > > @@ -77,6 +77,7 @@ > > #include > > > > #include "math_private.h" > > +#include "polevll.c" > > If a file contains inline function definitions and is intended only to > be included into another file and not compiled separately, shouldn't > its name be spelled polevll.h ? > Well, actually, the functions in polevll.c should have been copied into ld80/e_powl.c, and polevall.c should never have been committed. Unfortunately, the code was not reviewed for correctness. I've made the minimum changes to address the two issues I've noted. Feel free to either copy the functions and delete the polevall.c or rename it. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180715171737.GA31164>