From owner-svn-src-all@freebsd.org Sat Mar 31 19:39:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3DFDF7AAF6 for ; Sat, 31 Mar 2018 19:39:20 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C114731FC for ; Sat, 31 Mar 2018 19:39:20 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wr0-x22c.google.com with SMTP id y55so10415182wry.3 for ; Sat, 31 Mar 2018 12:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=Olqr3SH+/fwvOK7YPk07VQFeypuJVlK/6L3mSk8EsaM=; b=Fbv7nAZO9nWaqwIQ2lnEDXdrwwIsfIo6SXt6Zedm4iQER8+FHgJwexIXkxb2qwVYPZ eYUmbCvOeED4JTTL4NYMtNdUCkUY/EqbWxOk9PbFFVs0647AHHInRIGfCGrEzlAnYime By/kJwBzsnZRffnA3E13+heDiHEG3kod0lvJUunj9/FuzXD5OHrLbxnKxK9cThrvHgz4 TwUf+I7CJGj58pNF8H8gcsqt7rWt7QgUz0u8VUmF/fa1mgw54GEHAEl+Lh9zT88UaB6a 4lO7+3PUw9yWuo+ekl7j4l6NfGVLkpXKAJKoWagykkpIst8fdVtQ8U+nVzFK4V9rBF7v eLrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=Olqr3SH+/fwvOK7YPk07VQFeypuJVlK/6L3mSk8EsaM=; b=eR1z+E4AtowHYYWOrYjUpapNo9ervyDI41q3TyCLXRGda0BiifqLPYyHqCZ9EbIFgb wJvBeQHhkAPREEZOgYxoGQwEylD35g+NB49J6k2CbedWdi0S+OjBOkqEceJTM+i/JoUi an1dRfG9maztkEDZgiwcv1BOcRDZ3/GQh4T9WXRZbw8OJPTZH2S7E88Dmlex2QV7zVjU 4aof2Eo1nW5IxslfKecs7OBYlkKX/FJ6lrsRPD3KQ23zxzmXEMFRigbeQMAlBGsdSNen jzu24pa8PB9nMYpDuZgA16+5q+fnUji+kxeFk2BZW6ZuZi/N/ONmogKrtDKPki+iFpec uV9A== X-Gm-Message-State: AElRT7Hf1twJWgRGagVUne/63XRaa1taKxXEvU2iKvh68rn36LIR30zb 2TLyzvHmMzWDc0bcFTm34IJEUz2txE0= X-Google-Smtp-Source: AIpwx4/2iMNpZTKRPLb3Ah0bob02LVQ6wa+lkPvmoZDWyIWHWVLJ3AbuzARj2lPYcgT9TYdTI81e7A== X-Received: by 10.223.157.3 with SMTP id k3mr2686675wre.179.1522525158503; Sat, 31 Mar 2018 12:39:18 -0700 (PDT) Received: from [10.10.1.111] ([185.97.61.1]) by smtp.gmail.com with ESMTPSA id 134sm11202687wmm.42.2018.03.31.12.39.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Mar 2018 12:39:17 -0700 (PDT) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r327559 - in head: . sys/net To: Slawa Olhovchenkov , Eugene Grosbein Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801042005.w04K5liB049411@repo.freebsd.org> <5A4E9397.9000308@grosbein.net> <20180105131105.GB5368@zxy.spb.ru> Message-ID: <4598904f-fab2-a094-3887-6e9c5e6a4cc2@freebsd.org> Date: Sat, 31 Mar 2018 20:40:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180105131105.GB5368@zxy.spb.ru> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 19:39:21 -0000 On 05/01/2018 13:11, Slawa Olhovchenkov wrote: > On Fri, Jan 05, 2018 at 03:50:31AM +0700, Eugene Grosbein wrote: > >> 05.01.2018 3:05, Steven Hartland wrote: >> >>> Author: smh >>> Date: Thu Jan 4 20:05:47 2018 >>> New Revision: 327559 >>> URL: https://svnweb.freebsd.org/changeset/base/327559 >>> >>> Log: >>> Disabled the use of flowid for lagg by default >>> >>> Disabled the use of RSS hash from the network card aka flowid for >>> lagg(4) interfaces by default as it's currently incompatible with >>> the lacp and loadbalance protocols. >>> >>> The incompatibility is due to the fact that the flowid isn't know >>> for the first packet of a new outbound stream which can result in >>> the hash calculation method changing and hence a stream being >>> incorrectly split across multiple interfaces during normal >>> operation. >>> >>> This can be re-enabled by setting the following in loader.conf: >>> net.link.lagg.default_use_flowid="1" >>> >>> Discussed with: kmacy >>> Sponsored by: Multiplay >> RSS by definition has meaning to received stream. What is "outbound" stream >> in this context, why can the hash calculatiom method change and what exactly >> does it mean "a stream being incorrectly split"? >> >> Defaults should not be changed so easily just because they are not optimal >> for some specific case. Each lagg has its own setting for flowid usage >> and why one cannot just use "ifconfig lagg0 -use_flowid" for such cases? > Irrelevant to RSS and etc. flowid distribution in lacp case work very > bad. This is good and must be MFC (IMHO). There was no concrete conclusion to this thread and I've not had time to look into this more and it's on my open list to MFC to stable/11 in time for 11.2. Even given the drop in performance, I think we should prefer correctness over increased performance and given the new default can still be overridden in loader.conf I'm looking to MFC this shortly unless I get any strong objections with a clear path forward.     Regards     Steve