From nobody Mon Jan 12 17:33:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqfbj2l5lz6Ns8Z for ; Mon, 12 Jan 2026 17:33:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqfbj1TLfz479Y for ; Mon, 12 Jan 2026 17:33:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768239185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kEkJ6cL8n02m8y9K6zkFa17kx7YO/oM+pnd67dJFLwI=; b=UHTIvRyCpJe/V0YarK3j4fX43zjpcGdFaYFgiCO1l+qil3L0E1OUT9XuBGbnOknnMFPqVd Oo9mqJ7JAsksD7RZ9tS5Qt5uPkaBwvRLyKvVYANPuuTqhtbr0ZXm9G1KrbDUanHsfNzij4 u5hZBEtrTsCdr3RNA8XYQzE0DhO0YXAxn7r7fjd2LzIzEALkeIQVNRkFfbJzKFfIDvOhVM E57apvGJeT/HQbZgnbiA5vJ6sZTdVNS6rG3dzo30pxeKS7AhjZ+lsyV3lVd0cef3NdCUjK QhIJ4M2CSRE+G+zutt8Rje/h4HUJLshJv87XVpcyAh/6krP0aIJ6dwlEbgmLqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768239185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kEkJ6cL8n02m8y9K6zkFa17kx7YO/oM+pnd67dJFLwI=; b=FsLMkRSRK5ni1S0FsKPFqx/K0rO8VXpbwVQWHk/JWF1jieUN4tDiZfUilYattakGGGnWXS MUEji1F5wKec15wd0oFTDrTV15jNUy5eVvnTBinQOf+IVLiPItXr/4AuxJyO8fngqyQGBT lm/C9kacEDE79wPHJ2YWSJ22OMOo6T9Rh/4+Sy3Inu6LKr5KRC7W9P5qUUJJp3R3B2X5qx VVmsT5fyWi+ahkkGkEH4Ge8OSBsR0SRn0ain/BY25lwme4Y9z8orXuDaQE5mLc5go3gZov H9zx/Wpofbk60TbZV5dC1ofbY0/mGCwpixezGIB+vFujwcOMcKpWCvPcY/XrOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768239185; a=rsa-sha256; cv=none; b=bV2XU08UIWl2fYYHg591tStcE65zSgVqZOANtYntYjQZy0VTczQGElSHcuPdi5LYjfnWkH t37HnHtNEwWwCAEPxEhdpx3wixDQ9o6ezVuik/pExcmx/nAPE/eoORvFsezzcFFpLgGaGn Ym9YVzmt0/3lk0sRl3icomG4svTj2kMYS+DYzENHPpeDhpkrJ8tUnSYVVTptX4x9HlhXbM b/vh/AFc7Ge5o0n+6VbriVUNoZGadNr3v//zTmadJRvPcG5+4wsDCetAMkAIK7roYL7vE4 QkYl9iBxEe5c+gO+xPDm8GVNwL0vDO6/7LrZ7XpThBa8fRg669EFV2CkVDFPXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqfbj11gGzcrc for ; Mon, 12 Jan 2026 17:33:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36ae5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 17:33:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: da358db1cba7 - stable/13 - ng_tty: avoid the sign extention of char List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: da358db1cba7402059187bd74313fa18601df609 Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 17:33:05 +0000 Message-Id: <69653051.36ae5.58bebe60@gitrepo.freebsd.org> The branch stable/13 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=da358db1cba7402059187bd74313fa18601df609 commit da358db1cba7402059187bd74313fa18601df609 Author: Ahmad Khalifa AuthorDate: 2026-01-06 02:07:29 +0000 Commit: Ahmad Khalifa CommitDate: 2026-01-12 17:28:02 +0000 ng_tty: avoid the sign extention of char When c is compared to sc->hotchar, both undergo integer promotion, which can lead to c being sign extended. Fix this by casting c to an unsigned char. Reviewed by: kevans MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54544 (cherry picked from commit 9b2478f60bfda663c84b48e272a2293159e1b0a0) --- sys/netgraph/ng_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 0e3230a66f66..200a72336110 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -489,7 +489,8 @@ ngt_rint(struct tty *tp, char c, int flags) m->m_pkthdr.len++; /* Ship off mbuf if it's time */ - if (sc->hotchar == -1 || c == sc->hotchar || m->m_len >= MHLEN) { + if (sc->hotchar == -1 || (u_char)c == sc->hotchar || + m->m_len >= MHLEN) { sc->m = NULL; NG_SEND_DATA_ONLY(error, sc->hook, m); /* Will queue */ }