From owner-svn-src-head@FreeBSD.ORG  Fri Oct  4 21:25:55 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id EF2B6C01;
 Fri,  4 Oct 2013 21:25:55 +0000 (UTC)
 (envelope-from jilles@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id DCDDE27A6;
 Fri,  4 Oct 2013 21:25:55 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r94LPtPq081349;
 Fri, 4 Oct 2013 21:25:55 GMT (envelope-from jilles@svn.freebsd.org)
Received: (from jilles@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r94LPtVK081348;
 Fri, 4 Oct 2013 21:25:55 GMT (envelope-from jilles@svn.freebsd.org)
Message-Id: <201310042125.r94LPtVK081348@svn.freebsd.org>
From: Jilles Tjoelker <jilles@FreeBSD.org>
Date: Fri, 4 Oct 2013 21:25:55 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r256060 - head/usr.sbin/kldxref
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2013 21:25:56 -0000

Author: jilles
Date: Fri Oct  4 21:25:55 2013
New Revision: 256060
URL: http://svnweb.freebsd.org/changeset/base/256060

Log:
  kldxref: Do not depend on the directory order.
  
  Sort the filenames to get a consistent result between machines of the same
  architecture.
  
  Also, sort FTS_D entries after other entries so kldxref -R works properly in
  the uncommon case that a directory contains both subdirectories and modules.
  Previously, this may have happened to work, depending on the order of files
  in the directory.
  
  PR:		bin/182098
  Submitted by:	Derek Schrock (original version)
  Tested by:	Derek Schrock
  Approved by:	re (delphij)
  MFC after:	1 week

Modified:
  head/usr.sbin/kldxref/kldxref.c

Modified: head/usr.sbin/kldxref/kldxref.c
==============================================================================
--- head/usr.sbin/kldxref/kldxref.c	Fri Oct  4 19:57:47 2013	(r256059)
+++ head/usr.sbin/kldxref/kldxref.c	Fri Oct  4 21:25:55 2013	(r256060)
@@ -274,6 +274,16 @@ usage(void)
 	exit(1);
 }
 
+int 
+compare(const FTSENT *const *a, const FTSENT *const *b)
+{
+	if ((*a)->fts_info == FTS_D && (*b)->fts_info != FTS_D)
+		return 1;
+	if ((*a)->fts_info != FTS_D && (*b)->fts_info == FTS_D)
+		return -1;
+	return strcmp((*a)->fts_name, (*b)->fts_name);
+}
+
 int
 main(int argc, char *argv[])
 {
@@ -315,7 +325,7 @@ main(int argc, char *argv[])
 		err(1, "%s", argv[0]);
 	}
 
-	ftsp = fts_open(argv, fts_options, 0);
+	ftsp = fts_open(argv, fts_options, compare);
 	if (ftsp == NULL)
 		exit(1);