From owner-freebsd-usb@freebsd.org Thu Jul 2 10:06:58 2020 Return-Path: Delivered-To: freebsd-usb@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D5828350A48 for ; Thu, 2 Jul 2020 10:06:58 +0000 (UTC) (envelope-from jbe-mlist@magnetkern.de) Received: from sapphire.magnetkern.de (sapphire.magnetkern.de [185.228.139.199]) by mx1.freebsd.org (Postfix) with ESMTP id 49yDKG0fPRz4byc for ; Thu, 2 Jul 2020 10:06:57 +0000 (UTC) (envelope-from jbe-mlist@magnetkern.de) Received: from titanium (p5dd45c70.dip0.t-ipconnect.de [93.212.92.112]) by sapphire.magnetkern.de (Postfix) with ESMTPSA id 7264E1C78; Thu, 2 Jul 2020 10:06:56 +0000 (UTC) Date: Thu, 2 Jul 2020 12:06:55 +0200 From: Jan Behrens To: Hans Petter Selasky Cc: "freebsd-usb@FreeBSD.org" Subject: Re: USB reset fails when using a LimeSDR Mini on FreeBSD Message-Id: <20200702120655.73d1111e2de81c626be78139@magnetkern.de> In-Reply-To: <9e14575a-5c8b-28c8-6593-22019a21e7e7@selasky.org> References: <20200625121052.e9f7e7cbeb68fad264ec80a9@magnetkern.de> <0ec3e5a3-7f31-d1cd-6862-6066c431aa80@selasky.org> <20200626135151.e5542cf97fad213c4ad661f2@magnetkern.de> <5c0729f9-9e98-52f7-a5cb-6c5dfd2287a3@selasky.org> <20200626172851.872f3a08fa6e632666683230@magnetkern.de> <20200627144419.f14371695d9b62ea99106c4a@magnetkern.de> <20200627173604.7f7b7777140e66dbad812fc7@magnetkern.de> <20200627180420.4b8012fb@ernst.home> <20200702103523.adb0566bcc7b6e354905a8a5@magnetkern.de> <97c8fd11-9200-dff7-4c68-b0b80cc44871@selasky.org> <20200702104743.223e98c325806025704703f2@magnetkern.de> <20200702111538.e7edf0ae8d10ec7ede9acebb@magnetkern.de> <9e14575a-5c8b-28c8-6593-22019a21e7e7@selasky.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49yDKG0fPRz4byc X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jbe-mlist@magnetkern.de designates 185.228.139.199 as permitted sender) smtp.mailfrom=jbe-mlist@magnetkern.de X-Spamd-Result: default: False [-2.16 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[magnetkern.de]; NEURAL_HAM_LONG(-0.99)[-0.995]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.46)[-0.460]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-1.01)[-1.010]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:197540, ipnet:185.228.136.0/22, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[93.212.92.112:received] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 10:06:58 -0000 On Thu, 2 Jul 2020 11:23:32 +0200 Hans Petter Selasky wrote: > On 2020-07-02 11:15, Jan Behrens wrote: > > On Thu, 2 Jul 2020 10:54:27 +0200 > > Hans Petter Selasky wrote: > > > >> On 2020-07-02 10:47, Jan Behrens wrote: > >>> But wouldn't both drivers require access to the entries in /dev ? > >> > >> Yes, user-space drivers would require access to /dev, yes, but kernel > >> drivers not, like mouse, keyboard, storage, network. > >> > >>> Thus not every user could mess with any USB device, or do I get it > >>> wrong? > >> > >> A so-called composite USB device may appear like a USB storage device > >> (kernel driver) and a security token (firefox). Firefox can only grab > >> the device if you set the proper permissions for /dev of course, but the > >> reset device IOCTL then also becomes possible, which is why we currently > >> block it for non-root. > >> > >> --HPS > > > > Okay, so if I understand it right, the problem is due to devices that > > shall be partly accessible by root, and partly by users. Some device > > nodes (e.g. /dev/usb/2.2.1 ) while others (e.g. /dev/usr/2.2.2 ) are > > limited to root access only. An USB reset always affects all devices > > (e.g. also /dev/usb/2.2.2, 2.2.3, etc.), right? > > Yes, correct. Does /dev/usb/2.2.0 (in the given example) represent the device as a whole, or is it just another subdevice? (What's the correct term for "subdevice" in this context by the way? I assume "interface"?) I experienced that /dev/usb/2.2.0 and /dev/usb/2.2.1, 2.2.2, 2.2.3, etc. get treated differently when I reset the LimeSDR Mini with "usbconfig -u 2 -a 2 reset". The devices 2.2.1 and up are supposingly re-created (and have their access rights reset), while the device 2.2.0 maintains any manually changed access rights. Is it correct that 2.2.0 identifies the device as a whole? Or is this just the first/default interface? Is there any node in the /dev filesystem, which semantically refers to the whole hardware device? > > > Disregarding implementation complexity, I'd say that resetting a USB > > device should only be possible if a user has access to all sub-devices > > (or even better to a special device node that represents the device as > > a whole). > > Maybe we can check if any kernel side drivers are attached at the time > of reset device. It might be racy, because kernel drivers can be loaded > and attached at any time. But it will work. > > What do you think? I'm not sure if this is (from a semantic point of view) the best thing to do. I would say you should only be able to reset a device if you have been granted access to the device as a whole (including all interfaces/subdevices/whatever), as the reset seems to affect all of those. > > > > > That sounds better than adding a sysctl option to me. But I assume that > > would require a lot of changes in the code? > > If a simple rule can be formulated, I could implement it in the generic > USB kernel code. > > --HPS Regards, Jan