From owner-freebsd-arm@freebsd.org Sun Apr 11 23:06:08 2021 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E6D95E204C for ; Sun, 11 Apr 2021 23:06:08 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound4s.ore.mailhop.org (outbound4s.ore.mailhop.org [54.185.97.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FJSCg4zhqz4kT7 for ; Sun, 11 Apr 2021 23:06:07 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1618182366; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=c+pM2eCyUdp206hQnhJkAjsc2JlqAMhD+WZ5LcKP7tVzSsBK/74MBK5VXYQWcNywIQ7HCqcv525Jt QCiNKq/ZV6VNimCl5VWX95NIN1EPTWd9TpE5IVvyfhY7wWYn9UL20xcHTEsb/DYrQK4QWT91K7LjdV ORu2lidB3ILB1cWxm//Rl4NSI7TUbmzL6bnsRAFdeBXu29cHWjqv6y9qi4F0sIYpFAdaqcHkrlR5j9 f9GlYJr96Rzh/RNUDonv28FcJrPjffO/ORbZ/YFPUvU+GexeIJXsdlpNYEo/V+uDF01MAUPrefyQvx nbHKyvl+WBABaUhq/lPtyY5gUOUAsvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=OqLGtw15RCo0esvSRik+UKxpT/XehmWkUsdyX7Z4vjg=; b=oAS6rmNYJ/X2/nvQVS2aUBCf78TDLKHXFwO1x2pYqoCgTK2InJ571+0wWDfOiUmb6ipMyqwCQU10y 6vkKiZvlLjJa6tqGZE0+uKUnVN+xWi6NEwOfrrL9B6AK2ybKxaHYoSS6xx8iNfisGEIh7RJdbDdxtn fMc8WcarSLJeZSBOe/fpbagTUzkgVJF0Rs9hMVsHPWBsj6+P1ftIOKlSSs996Bc20lIFfZCEEk32Sb bblEhO3EgHUQInfDKHM1MXn75Ys5XNbjcJieowwSWabjSZX2yCJQdlsesZYF+X0b0e7FbCanJcU5c9 6AjQCKAhgWI/kbOiVIgUjkeDikpeV3Q== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=OqLGtw15RCo0esvSRik+UKxpT/XehmWkUsdyX7Z4vjg=; b=lNLKNRgEkBVwaNSRkhPTYoOyZUeOcvD6VbLvh+K4CMrD6FpAYJ2z2qDKtH2aAu8QS01X+oWWMq4lQ fG6GNFICp4Rcq8jpQJxiBPpFQVBS/UVjyrH0VIztus7plpRCvl30Y5Q85RBWD98EOYVrvJz1+EVePj ikn3fItjx/bdu9p78tlTLr5mUkFYNJnrDioFXiS1p/pO+iAp+2EkqjUFjelkk4GQIpme4w+BOGZ0jV 0fS2JO0OgjFF11VHSwAXT4kOrvvmgtSCRFzl1DkquMApNMFt0m4xa3eTO8LQ3U3wzJzGGDV7EFd8UY 9nvvRyHtSioOMMhZdCoUzcQ5APpMhDQ== X-Originating-IP: 67.177.211.60 X-MHO-RoutePath: aGlwcGll X-MHO-User: 7ca34bf4-9b1a-11eb-a62a-89389772cfc7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 7ca34bf4-9b1a-11eb-a62a-89389772cfc7; Sun, 11 Apr 2021 23:06:05 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 13BN62Ug013480; Sun, 11 Apr 2021 17:06:02 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: No dwc0 on bananapi m1 with Linux 5.10 devicetree From: Ian Lepore To: Emmanuel Vadot Cc: "freebsd-arm@FreeBSD.org" Date: Sun, 11 Apr 2021 17:06:02 -0600 In-Reply-To: <20210411213728.7a53a7a91c2aa3c930f5abc6@bidouilliste.com> References: <1sKA_1f0z4MvqNKPTG1kiNCHauRdILGumygIn6w0H-XBzxg_cTV0c-01SCnrUcmzy96RCoE2zA4khWzwo6DQQymVphL7zpjOVx5c48lXAXU=@protonmail.com> <20210411213728.7a53a7a91c2aa3c930f5abc6@bidouilliste.com> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FJSCg4zhqz4kT7 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:54.184.0.0/15, country:US] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting FreeBSD to ARM processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2021 23:06:08 -0000 On Sun, 2021-04-11 at 21:37 +0200, Emmanuel Vadot wrote: > On Sun, 11 Apr 2021 09:24:33 +0000 > qroxana via freebsd-arm wrote: > > > It seems the dwc0 no longer works after > > 6be3386466ab79a84b48429ae66244f21526d3df > > > > dwc0: mem 0x1c50000-0x1c5ffff irq > > 72 on simplebus0 > > dwc0: Can't reset DWC. > > device_attach: dwc0 attach returned 6 > > > > I've tried to revert this change on my bananapi m1 and dwc0 worked > > again. > > > > commit e7ffa3b5ce04742455c6bd4d8af0fdedd9978c77 > > Author: Emmanuel Vadot > > Date: Sun Jan 17 19:02:46 2021 +0100 > > > > Import devicetree files from Linux 5.10 > > > > diff --git a/src/arm/sun7i-a20-bananapi.dts b/src/arm/sun7i-a20- > > bananapi.dts > > index bb3987e..0b3d9ae 100644 > > --- a/src/arm/sun7i-a20-bananapi.dts > > +++ b/src/arm/sun7i-a20-bananapi.dts > > @@ -132,7 +132,7 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <&gmac_rgmii_pins>; > > phy-handle = <&phy1>; > > - phy-mode = "rgmii"; > > + phy-mode = "rgmii-id"; > > phy-supply = <®_gmac_3v3>; > > status = "okay"; > > }; > > > Hi, > > Sorry about that, > Upstream did warned me about this change but I was sure that we did > nothing with the phy-mode in dwc, should have check better. > > Please try this patch (I have no allwinner dwc based board here) : > From 72c709db9ec3eb9a132ffe893b1e95e29bca62ac Mon Sep 17 00:00:00 > 2001 > From: Emmanuel Vadot > Date: Sun, 11 Apr 2021 21:34:57 +0200 > Subject: [PATCH] dwc: Cope with recent dts changes > > Add rgmii-id to the list of mode where we need to configure it as > rgmii. > --- > sys/dev/dwc/if_dwc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/dev/dwc/if_dwc.c b/sys/dev/dwc/if_dwc.c > index 776d0d0dc39..0549874a977 100644 > --- a/sys/dev/dwc/if_dwc.c > +++ b/sys/dev/dwc/if_dwc.c > @@ -1575,7 +1575,7 @@ dwc_attach(device_t dev) > > node = ofw_bus_get_node(dev); > if (OF_getprop_alloc(node, "phy-mode", (void **)&phy_mode)) { > - if (strcmp(phy_mode, "rgmii") == 0) > + if (strcmp(phy_mode, "rgmii") == 0 || strcmp(phy_mode, > "rgmii-id") == 0) sc->phy_mode = PHY_MODE_RGMII; > if (strcmp(phy_mode, "rmii") == 0) > sc->phy_mode = PHY_MODE_RMII; > This should probably be: node = ofw_bus_get_node(dev); if (mii_contype_is_rgmii(mii_fdt_get_contype(node))) sc->phy_mode = PHY_MODE_RGMII; -- Ian