Date: Fri, 8 Jul 2011 10:53:00 -0700 From: Peter Wemm <peter@wemm.org> To: Attilio Rao <attilio@freebsd.org> Cc: Sergey Kandaurov <pluknet@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: [PATCH] Add MAXCPU as a kernel config option and quality discussion on this Message-ID: <CAGE5yCrmaPciAr0jtr1C978C0SPcqM5=xGJ1yovGauEY3NUjRg@mail.gmail.com> In-Reply-To: <CAJ-FndDZu0cBrVbH3W%2B8Tj86T5h%2BwwWqUVnjJO1rtXopKodNOA@mail.gmail.com> References: <CAJ-FndDZu0cBrVbH3W%2B8Tj86T5h%2BwwWqUVnjJO1rtXopKodNOA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 8, 2011 at 8:37 AM, Attilio Rao <attilio@freebsd.org> wrote: > In my case, I think that including opt_maxcpu is a viable panacea, but > in general, after discussing with peter@, probabilly the better idea > would be having a centralized script that does pre-processing before > to start compiling and set with the right values all those constants > (something like genassym.c, but of course with a different purpose). At the risk of fragmenting the thread, I wanted to clarify the goals of what I was talking about last night. What makes me happy is when I can change a value in my config file, and after running 'config FOO; make depend; make', the 6 files affected by the value get recompiled and that's it. That's the point of keeping the dependencies limited. Putting stuff in opt_global.h defeats this. Putting opt_maxcpu.h into a widely included file also defeats this. The genassym/centralized script approach also defeats it. I think the issue you're mainly worried about is correctly detecting when the config override value failed to be pulled in for something that is important. What I suggested earlier will do that and will keep me happy by not adding false dependencies. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV "All of this is for nothing if we don't go to the stars" - JMS/B5 "If Java had true garbage collection, most programs would delete themselves upon execution." -- Robert Sewell
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGE5yCrmaPciAr0jtr1C978C0SPcqM5=xGJ1yovGauEY3NUjRg>