From owner-svn-src-projects@FreeBSD.ORG Sat May 28 17:13:15 2011
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id AC1AC106566B;
Sat, 28 May 2011 17:13:15 +0000 (UTC)
(envelope-from nwhitehorn@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
by mx1.freebsd.org (Postfix) with ESMTP id 9D0648FC14;
Sat, 28 May 2011 17:13:15 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p4SHDFfM093534;
Sat, 28 May 2011 17:13:15 GMT
(envelope-from nwhitehorn@svn.freebsd.org)
Received: (from nwhitehorn@localhost)
by svn.freebsd.org (8.14.4/8.14.4/Submit) id p4SHDFnF093532;
Sat, 28 May 2011 17:13:15 GMT
(envelope-from nwhitehorn@svn.freebsd.org)
Message-Id: <201105281713.p4SHDFnF093532@svn.freebsd.org>
From: Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Date: Sat, 28 May 2011 17:13:15 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc:
Subject: svn commit: r222427 - projects/pseries/powerpc/ofw
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src " projects"
tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 May 2011 17:13:15 -0000
Author: nwhitehorn
Date: Sat May 28 17:13:15 2011
New Revision: 222427
URL: http://svn.freebsd.org/changeset/base/222427
Log:
Check whether the return value of OF_open is 0 only, as -1 is potentially
a valid ihandle.
Modified:
projects/pseries/powerpc/ofw/rtas.c
Modified: projects/pseries/powerpc/ofw/rtas.c
==============================================================================
--- projects/pseries/powerpc/ofw/rtas.c Sat May 28 16:30:24 2011 (r222426)
+++ projects/pseries/powerpc/ofw/rtas.c Sat May 28 17:13:15 2011 (r222427)
@@ -83,7 +83,7 @@ rtas_setup(void *junk)
}
OF_package_to_path(rtas, path, sizeof(path));
rtasi = OF_open(path);
- if (rtasi == -1 || rtasi == 0) {
+ if (rtasi == 0) {
rtas = 0;
printf("Error initializing RTAS: could not open node\n");
return;