From nobody Tue Mar 3 18:41:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQPm661TDz6TTHw for ; Tue, 03 Mar 2026 18:41:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQPm628bwz3STc for ; Tue, 03 Mar 2026 18:41:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-35980423087so1552222a91.3 for ; Tue, 03 Mar 2026 10:41:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772563312; cv=none; d=google.com; s=arc-20240605; b=YUV6WV61uSZH4ZVXdwCvB8JphVSAad1xfRaiZ2eUQ8lb4xRLCYgJtL4IO8BqhuuvQy brYbSr9M2GDXkuDTs1LeTjN8hT2nCblVj5nzV2qKbuzbDFeiHghn/vHC2HLGawsUW2ki z5NcpcKdz+B4yWCAOm+NK403nx9gKYNeE15rYP/EWl+2R3eJBCUbK6qtY0bFvRKi9r3t XG+SaJtyUagrnPEfKhOIbrhQOwQJYZRNhMejJJidlnZc3wBLAkMUk+xRNUvrIv50hmwV qLu20B5fc/bUgcpq0g9m7mi2v6JWMQ07XUuDHW6Jsu4yL0KAfLbLMRjcIpndfEsjyf3f vXPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=2OeCHzisgkJfQBpCFBHvZTubw7E1yadYrpIs+trCzbg=; fh=hD0Aq3orfj1LznHn9HN25cTKL8axyEnp9RvQShnCWyE=; b=gLQ6Dj9HTpZVFlW6DYw8uBEvzS/c1A0d/TeFqknyADyjq1FXEN0d9ongnfEErsBOJA Ow+kbge7D8IYuFB0zIDmdcaGmJQ5yFHQsnBaXFB0qqn1C9cNjsuobgIlGH9OIOS2fr8f OAWlkFZ2YbUHXb24nu8hko7gGSddveELhzOWO/6Jo8Mmnkiv4p5P3QjL4fw1KNH3mUQi 0NRog7obgvrG8XTfOCv4vAE7F63mIHhtUkp603Y7TbP4C3ItbTWGRaqsOjKBa1re3N+o MBuHCOp995aOrtqFGqkYmqWHMrWyarWvypcQui7ASG8TzVEHWAkA4735NIyLETQO0oXC yJ1w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1772563312; x=1773168112; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2OeCHzisgkJfQBpCFBHvZTubw7E1yadYrpIs+trCzbg=; b=N0ayZcfIq9k4dH7U8zMU3ZAGoGsI3SkOIMYvgUMZKKUkO0JF4wjw35Z6ciPu1cZXUE JSMkv3FwsZb/BV/ttXHOcEp/saWKp1i5AaCWrekGbhfq471JbEspQWU4TA2eiAEbO3GC PaagcU0lEFHfEe/fd1vaMYeIz/bDIBvU+XF3ymO6YI3rhxeNi78oqgAQO0dlAtXvXzy9 D6YUxxr3UhrY91tZtyp4rOx0cfEvo3yMFyD026+okg+2r5E1UU56SuM62Jl9OOdat6Tt a4Jt10b6c9X2zWKkKlzggTiwVcrqEgXAUKqlwqO+dnUTmLipAPJapgSUN67vpVJ/O4dw 5myw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772563312; x=1773168112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2OeCHzisgkJfQBpCFBHvZTubw7E1yadYrpIs+trCzbg=; b=HdvDkhYjjDGtRYWNGmVZ+t9Q4irQVXWBY6FfQIsuIGLWshpT7bRFSUb975w+NQJdtN Qb9rELUG5yrK/y7hhE0E0mIQWZVi2Ev/r0OYnAG1LGEmxF/ZaLHKfv1+NRF661Xgh63Z MbuJjl08WPA4E4+xu/lJnXhzvsqW8N7M5cl4J/8DiNIYn9oLDIWi2HrpSgLD+XCmlvFO S78D/yis2yN7XgW9SLEWZqUCHZCe/JkRxDcC5qLQvUcNCxLaivTUknKw+8jRMO3z73JC e1EtiQd1umGxRl2mabWzBoiJUEOqctdieIHSkEHazaHSvooHmtuumqWR2XbjNh90Z/jM 3Txg== X-Forwarded-Encrypted: i=1; AJvYcCUhUpekwPAFBsZ3spQJDzgRt6/RtNfDEKof8W9LEV3NVWQ58oJrg9EFba45e7/j3hFTlRPy9L0RuRCjpw3KX3dPFosx@freebsd.org X-Gm-Message-State: AOJu0YxQSpjGJdiQBPd85QzjfdoXdct8FR9l/VjT2w3NC99D5rRm9n1C yK1hDQhd+ipdnkwH+TOyy9X3oOqcG5fao+q53gH/V6Tz/tgUskUB0C7iBZ2Gj1rpzysk3ERu5PB MbujZ3GjcmyAGvfpxqlXLBK5Xi+tfeJlcheiDCL+BDtsNflnjp2Q9vNc= X-Gm-Gg: ATEYQzyFLkRd/kAyQ8SwWxeaqlDFMVLExMwuSleI8uQMZIj/KDF9Qvi55qU5IC0M/gI B7NX/wDN5FziqJxTe9ogcO2m+dXQicj7iaojWqKAVrD05xlTniE/XCZW/0zR1AB9CiS2y8XbqUx hpZZYVNiLWAKfMqIChTnFjGg+xUUpnJ1bh0R6zqsCPWg2zvHHP/0RetXC2ZHuwygpoeMlWqYRRA 7HidOIz96ZCc2RdaQ7a6TRxN0Z5oQbOs7wbtn4rL+RPpwvuPLvtm7mn0bbDl9vj72CwWengl+AB i7N3Do4= X-Received: by 2002:a17:90b:5747:b0:354:a065:ec3e with SMTP id 98e67ed59e1d1-35965cd0f50mr13790421a91.26.1772563312113; Tue, 03 Mar 2026 10:41:52 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69a668aa.3785e.4a16f236@gitrepo.freebsd.org> <1s9oq316-3q4o-9273-3qos-3n3o793ns725@mnoonqbm.arg> In-Reply-To: <1s9oq316-3q4o-9273-3qos-3n3o793ns725@mnoonqbm.arg> From: Warner Losh Date: Tue, 3 Mar 2026 11:41:39 -0700 X-Gm-Features: AaiRm52dwUYZ4JsA5Fd8hJayeDaLwyMlBaQwsXvpS2i3hliWPJdQaXPZ8JzSmlM Message-ID: Subject: Re: git: c47cefba8312 - main - Only build USB-related modules if MK_USB != no To: "Bjoern A. Zeeb" Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000008f8938064c230ee7" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQPm628bwz3STc X-Spamd-Bar: ---- --0000000000008f8938064c230ee7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 3, 2026 at 11:29=E2=80=AFAM Bjoern A. Zeeb wro= te: > On Tue, 3 Mar 2026, Enji Cooper wrote: > > > The branch main has been updated by ngie: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dc47cefba831240a1b3de375f18134b9= 3cf998f5c > > > > commit c47cefba831240a1b3de375f18134b93cf998f5c > > Author: Enji Cooper > > AuthorDate: 2026-03-03 04:49:54 +0000 > > Commit: Enji Cooper > > CommitDate: 2026-03-03 04:50:03 +0000 > > > > Only build USB-related modules if MK_USB !=3D no > > > > This change moves the thunderbolt module and other USB modules under= a > > MK_USB !=3D no conditional to ensure that users not desiring USB sup= port > > can easily build systems without USB-specific drivers using this kno= b. > > > > MFC after: 1 week > > Reviewed By: imp > > Differential Revision: https://reviews.freebsd.org/D55576 > > --- > > sys/conf/kern.opts.mk | 5 +++++ > > sys/conf/kmod.mk | 8 ++++++-- > > sys/modules/Makefile | 16 ++++++++++------ > > 3 files changed, 21 insertions(+), 8 deletions(-) > > There is a hige load of further devices which depend on USB which are not > part of the current set excluded; I assume they will now break with > dependency > issues if USB is no longer built but these modules are built. > > Is there any plan to also "hide" all the other modules? > As I said in my review, I'm generally uneasy about this trend... Warner --0000000000008f8938064c230ee7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 3, = 2026 at 11:29=E2=80=AFAM Bjoern A. Zeeb <bz@freebsd.org> wrote:
On Tue, 3 Mar 2026, Enji Cooper wrote:

> The branch main has been updated by ngie:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Dc47cefba831240a1b3de375f18134b93cf998f5c<= /a>
>
> commit c47cefba831240a1b3de375f18134b93cf998f5c
> Author:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org>
> AuthorDate: 2026-03-03 04:49:54 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org>
> CommitDate: 2026-03-03 04:50:03 +0000
>
>=C2=A0 =C2=A0 Only build USB-related modules if MK_USB !=3D no
>
>=C2=A0 =C2=A0 This change moves the thunderbolt module and other USB mo= dules under a
>=C2=A0 =C2=A0 MK_USB !=3D no conditional to ensure that users not desir= ing USB support
>=C2=A0 =C2=A0 can easily build systems without USB-specific drivers usi= ng this knob.
>
>=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 1 week
>=C2=A0 =C2=A0 Reviewed By:=C2=A0 =C2=A0 imp
>=C2=A0 =C2=A0 Differential Revision: https://reviews.freebsd.o= rg/D55576
> ---
> sys/conf/kern.opts.mk |=C2=A0 5 +++++
> sys/conf/kmod.mk=C2=A0 =C2=A0 =C2=A0 |=C2=A0 8 ++++++--
> sys/modules/Makefile=C2=A0 | 16 ++++++++++------
> 3 files changed, 21 insertions(+), 8 deletions(-)

There is a hige load of further devices which depend on USB which are not part of the current set excluded;=C2=A0 I assume they will now break with d= ependency
issues if USB is no longer built but these modules are built.

Is there any plan to also "hide" all the other modules?

As I said in my review, I'm generally uneasy= about this trend...

Warner
--0000000000008f8938064c230ee7--