Date: Thu, 29 Jun 2000 01:16:05 +0200 From: Martin Kraft <martin.kraft@fal.de> To: Juhana Sadeharju <kouhia@nic.funet.fi> Cc: trevor@jpj.net, tkato@prontomail.ne.jp, freebsd-ports@freebsd.org, freebsd-gnats-submit@freebsd.org Subject: Re: ports/18779 + ports/19200: New port: audio/xwave Message-ID: <20000629011602.B9138@eiche.priconet.de> In-Reply-To: <20000628133039Z3417-532%2B5166@nic.funet.fi>; from kouhia@nic.funet.fi on Wed, Jun 28, 2000 at 04:30:39PM %2B0300 References: <200006121020.DAA10189@freefall.freebsd.org> <Pine.BSI.4.21.0006120725510.14283-100000@blues.jpj.net> <20000627234642.A16228@eiche.priconet.de> <20000628133039Z3417-532%2B5166@nic.funet.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
Diskussing the differences and advantages of ports/18779 and ports/19200, as well as differences and advantages between the original xwave 0.6 by Kai Kollmorgen and some improvements by Juhana Sadeharju: On Wed, Jun 28, 2000 at 04:30:39PM +0300, Juhana Sadeharju wrote: > > Thanks for mailing to me. XWave2 is indeed not maintained by me anymore. > I succeeded to add a few improvements and correct some errors, but then > I had to stop because the original code was badly designed. For example, > I could not add a proper loop-play feature. > > My page "http://www.funet.fi/~kouhia/waves" has two versions: the XWave2 > and XWave2v2 with the loop-play patch found from Sunsite. It also has > an additional text-field entry for setting selection. With that version > I also goofed and breaked the rule "if it works, don't fix it" -- that is > why drawing fails slightly. I suggest to take that XWave2 version and > look how I added the loop-play patch. > > Though, I would like to know what is that maintained version you wrote about? Sorry, someoene else mentioned a maintained version. Do not know about one myself. > Martin Kraft wrote: > > >At this time and today's state of xwave 2, it is my suggestion, that we > >commit at least a port of the original xwave 0.6. > > How fast do you need the port? I suggest we take the XWave2v2 and fix the > bugs. The original 0.6 should be forgotten because my changes are quite > helpful: > [..] > So, I would not go back to original 0.6 version. I tested xwave2v2, and found it OK for my purposes. None of the problems I noticed for xwave2 occured. Updated my port/18779 for xwave2v2 (xwave2-981109). See below. I will not be able to contribute in programming enhancements to xwave or in removing bugs. No knowledes about all the techniques and ideas in this software. I only can try to port any further version. Juhana, there is no time pressure, but on the other side i guess that people would be happy with any running version of xwave to be ported to FreeBSD ASAP; further enhancements may follow and be ported later. Martin Kraft - - - - - - - - - - - - - - - - - - - - - - - - # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # . # ./pkg # ./pkg/COMMENT # ./pkg/DESCR # ./pkg/PLIST # ./patches # ./patches/patch-ab # ./patches/patch-ac # ./patches/patch-ad # ./patches/patch-ae # ./files # ./files/md5 # ./Makefile # echo c - . mkdir -p . > /dev/null 2>&1 echo c - ./pkg mkdir -p ./pkg > /dev/null 2>&1 echo x - ./pkg/COMMENT sed 's/^X//' >./pkg/COMMENT << 'END-of-./pkg/COMMENT' XAn audio player, recorder, editor for the XWindow System END-of-./pkg/COMMENT echo x - ./pkg/DESCR sed 's/^X//' >./pkg/DESCR << 'END-of-./pkg/DESCR' XXwave is an audio editor, player, recorder for XWindow System, X - supports editing of large files (on hdd), X - cut,copy,paste,merge, X - some effects (echo,reverse,swap channels,resample,volume), X - supports RIFF,AIFF,AIFC,AU X - Linux,SGI,SUN,FreeBSD X XThe user interface of xwave is based on the Athena Widget XSet and some Widgets from FWF. X Xxwave originally was written by XKai Kollmorgen <kkollmor@informatik.uni-rostock.de>. X X- Martin Kraft Xmartin.kraft@fal.de END-of-./pkg/DESCR echo x - ./pkg/PLIST sed 's/^X//' >./pkg/PLIST << 'END-of-./pkg/PLIST' Xbin/xwave Xlib/X11/app-defaults/XWave END-of-./pkg/PLIST echo c - ./patches mkdir -p ./patches > /dev/null 2>&1 echo x - ./patches/patch-ab sed 's/^X//' >./patches/patch-ab << 'END-of-./patches/patch-ab' X*** ../../xwave.orig/src/Imakefile Tue Nov 19 19:51:58 1996 X--- src/Imakefile Thu May 18 00:43:39 2000 X*************** X*** 21,26 **** X all:: $(PROGRAMS) X X depend:: X! $(DEPEND) $(EXTRA_INCLUDES) $(SRCS) >>Makefile X X X--- 21,26 ---- X all:: $(PROGRAMS) X X depend:: X! $(DEPEND) $(EXTRA_INCLUDES) -I/usr/X11R6/include $(SRCS) >>Makefile X X END-of-./patches/patch-ab echo x - ./patches/patch-ac sed 's/^X//' >./patches/patch-ac << 'END-of-./patches/patch-ac' Xdiff -rc ../../xwave.orig/src/audio.c src/audio.c X*** ../../xwave.orig/src/audio.c Tue Nov 26 11:13:44 1996 X--- src/audio.c Thu May 18 01:27:08 2000 X*************** X*** 31,36 **** X--- 31,37 ---- X #include <sys/types.h> X #include <sys/ioctl.h> X #include <signal.h> X+ #include "types.h" X X #include <X11/Intrinsic.h> X X*************** X*** 47,53 **** X #include <sys/audioio.h> X #endif X X- #include "types.h" X #include "audio_file.h" X #include "xwave.h" X #include "xwave_widget.h" X--- 48,53 ---- Xdiff -rc ../../xwave.orig/src/types.h src/types.h X*** ../../xwave.orig/src/types.h Wed Nov 6 23:41:53 1996 X--- src/types.h Thu May 18 01:26:54 2000 X*************** X*** 27,32 **** X--- 27,34 ---- X typedef unsigned char byte; X typedef byte bool; X X+ #define FreeBSD X+ X #ifdef FreeBSD X typedef unsigned long ulong; X #endif END-of-./patches/patch-ac echo x - ./patches/patch-ad sed 's/^X//' >./patches/patch-ad << 'END-of-./patches/patch-ad' Xdiff -rc ../../xwave.orig/FWF/Imakefile FWF/Imakefile X*** ../../xwave.orig/FWF/Imakefile Thu Feb 15 15:43:46 1996 X--- FWF/Imakefile Thu May 18 01:49:26 2000 X*************** X*** 9,14 **** X--- 9,15 ---- X MakeDirectories(all,$(ALLDIRS)) X X InitSubdirs($(SUBDIRS)) X+ DependSubdirs($(SUBDIRS)) X MakeObjectsSubdirs($(SUBDIRS)) X MakeExecsSubdirs($(SUBDIRS)) X GatherDescriptionSubdirs($(SUBDIRS)) Xdiff -rc ../../xwave.orig/FWF/src/Imakefile FWF/src/Imakefile X*** ../../xwave.orig/FWF/src/Imakefile Thu Feb 15 15:38:37 1996 X--- FWF/src/Imakefile Thu May 18 01:53:19 2000 X*************** X*** 34,39 **** X--- 34,40 ---- X X X InitSubdirs($(SUBDIRS)) X+ DependSubdirs($(SUBDIRS)) X MakeObjectsSubdirs($(SUBDIRS)) X MakeExecsSubdirs($(SUBDIRS)) X GatherDescriptionSubdirs($(SUBDIRS)) END-of-./patches/patch-ad echo x - ./patches/patch-ae sed 's/^X//' >./patches/patch-ae << 'END-of-./patches/patch-ae' X*** ../../edit.c Wed Jun 28 23:50:21 2000 X--- src/edit.c Wed Jun 28 23:52:47 2000 X*************** X*** 54,59 **** X--- 54,60 ---- X extern bool button_2; X X /* these conversion routines are also in graphics.c */ X+ /* Commented out. M. Kraft 2000-06-28 X int mg_sel_leftsample(float step,int x) X { X return(ceil(step*x-0.5)); X*************** X*** 73,79 **** X { X return((int)(((float)x+0.5)/step)); X } X! X X void begin_up(Widget w, XtPointer client_data, XtPointer call_data) X { X--- 74,80 ---- X { X return((int)(((float)x+0.5)/step)); X } X! */ X X void begin_up(Widget w, XtPointer client_data, XtPointer call_data) X { END-of-./patches/patch-ae echo c - ./files mkdir -p ./files > /dev/null 2>&1 echo x - ./files/md5 sed 's/^X//' >./files/md5 << 'END-of-./files/md5' XMD5 (xwave2v2.tar.gz) = b472c76e6ee67a734aacc22c499e8633 END-of-./files/md5 echo x - ./Makefile sed 's/^X//' >./Makefile << 'END-of-./Makefile' X# New ports collection makefile for: xwave X# Date created: 28 June 2000 X# Whom: Martin Kraft <martin.kraft@fal.de> X# X# $FreeBSD$ X# X XPORTNAME= xwave XPORTVERSION= 2v2 XCATEGORIES= audio XMASTER_SITES= http://www.funet.fi/~kouhia/waves/ XDISTNAME= xwave2v2 X XMAINTAINER= martin.kraft@fal.de X XUSE_IMAKE= yes XWRKSRC= $(WRKDIR)/xwave2-981109 X X# Sorry, no man page or other types of docs yet. X Xdo-install: X ${INSTALL_PROGRAM} ${WRKSRC}/src/xwave ${PREFIX}/bin X ${INSTALL_DATA} ${WRKSRC}/src/XWave ${X11BASE}/lib/X11/app-defaults X Xpost-install: X strip ${PREFIX}/bin/xwave X X.include <bsd.port.mk> END-of-./Makefile exit To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000629011602.B9138>