From owner-freebsd-fs Fri Oct 31 10:50:03 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id KAA27192 for fs-outgoing; Fri, 31 Oct 1997 10:50:03 -0800 (PST) (envelope-from owner-freebsd-fs) Received: from mail.cs.tu-berlin.de (root@mail.cs.tu-berlin.de [130.149.17.13]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id KAA27150 for ; Fri, 31 Oct 1997 10:49:52 -0800 (PST) (envelope-from wosch@cs.tu-berlin.de) Received: from panke.panke.de (anonymous222.ppp.cs.tu-berlin.de [130.149.17.222]) by mail.cs.tu-berlin.de (8.8.6/8.8.7) with ESMTP id TAA23089; Fri, 31 Oct 1997 19:48:00 +0100 (MET) Received: (from wosch@localhost) by panke.panke.de (8.8.5/8.6.12) id SAA00626; Fri, 31 Oct 1997 18:45:20 +0100 (MET) Message-ID: <19971031184519.12801@panke.de> Date: Fri, 31 Oct 1997 18:45:19 +0100 From: Wolfram Schneider To: Bruce Evans Cc: Don.Lewis@tsc.tdk.com, wosch@cs.tu-berlin.de, freebsd-fs@FreeBSD.ORG, roberto@keltia.freenix.fr Subject: Re: disabled symlinks References: <199710311325.AAA17135@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.79 In-Reply-To: <199710311325.AAA17135@godzilla.zeta.org.au>; from Bruce Evans on Sat, Nov 01, 1997 at 12:25:57AM +1100 Sender: owner-freebsd-fs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On 1997-11-01 00:25:57 +1100, Bruce Evans wrote: > >> } diff -u -r1.51.2.6 vfs_syscalls.c > >> } --- vfs_syscalls.c 1997/10/23 18:04:55 1.51.2.6 > >> } +++ vfs_syscalls.c 1997/10/30 22:24:47 > >> } @@ -1326,8 +1328,10 @@ > >> } return (error); > >> } vp = nd.ni_vp; > >> } error = vn_stat(vp, &sb, p); > >> } - if (vp->v_type == VLNK) > >> } + if (vp->v_type == VLNK && > >> } + (vp->v_mount->mnt_flag & MNT_NOSYMLINKFOLLOW) != 0) > > ^^ > > > >> This test looks backwards to me (it changes the behavior if the > >> new nosymlinkfollow option is not set). I'm also not clear as > >> to why the behaviour even depends on the option. > > It's also wrong because it breaks the setting of S_IFLNK. S_IFLNK was already set in vn_stat. -- Wolfram Schneider http://www.apfel.de/~wosch/