Date: Tue, 1 Mar 2011 01:21:28 +0200 From: C++ RTMP Server Support <support@rtmpd.com> To: Doug Barton <dougb@FreeBSD.org> Cc: Sylvio Cesar Teixeira <sylvio@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net Makefile ports/net/crtmpserver Makefile distinfo pkg-descr pkg-plist ports/net/crtmpserver/files crtmpserver.in Message-ID: <4334F7BE-149D-47D4-960D-8CD50B96DB7D@rtmpd.com> In-Reply-To: <4D6C1F63.4050202@FreeBSD.org> References: <201102281357.p1SDvcPD025719@repoman.freebsd.org> <4D6C1F63.4050202@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail-11-653024689 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hello, Thank you for the patch. It looks very nice and tight from my side. = However, I would like to ask you to delay the port 2 days so I will be = able to provide --pid switch and fix some other bugs inside its guts. = They are not critical, but I would like to take this opportunity to come = up with as clean as possible first version. And since I brought this up, crtmpserver has commits with = improvements/features/bug fixes daily (see = http://trac.rtmpd.com/timeline) What do you recommend for a "release plan"? Should I send you a daily patch or should I wait for, lets say, twice a = month/week? Best regards, Andrei On Mar 1, 2011, at 12:19 AM, Doug Barton wrote: > There are a few problems with the rc.d script for this port, but = overall it looks quite good. I think you've probably already seen this, = but just in case there is more information available at: > = http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scrip= ts.html >=20 > The biggest problem (that needs to be fixed) is that we do not like to = have code executed unconditionally by scripts, especially when it's only = appropriate at start time. The other bug is that although you specify = the ability to set _user in the comments, you write it unconditionally = at install time. It's ok not to allow setting of _user, but generally = it's preferred for services that run as a specific user so I fixed it = instead of removing the documentation. >=20 > The last changes are recommendations, use them at your discretion. = Since the config file seems to be required I added it to required_files. = This is a safety belt in rc.subr that will prevent the script from = trying to run the service if the file is missing. The other recommended = change is to use pgrep to find the pid, which unless I'm really missing = something is now present on all supported versions of FreeBSD. >=20 > Maintainer, please test these changes and let us know what you approve = ASAP. >=20 >=20 > hth, >=20 > Doug >=20 >=20 > On 02/28/2011 05:57, Sylvio Cesar Teixeira wrote: >> sylvio 2011-02-28 13:57:38 UTC >>=20 >> FreeBSD ports repository >>=20 >> Modified files: >> net Makefile >> Added files: >> net/crtmpserver Makefile distinfo pkg-descr pkg-plist >> net/crtmpserver/files crtmpserver.in >> Log: >> High performance RTMP/RTSP streaming server >> rtmpd is a high performance streaming server able to stream >> (live or recorded) in the following technologies: >> - To and from Flash (RTMP,RTMPE, RTMPS, RTMPT, RTMPTE) >> - To and from embedded devices: iPhone, Android >> - =46rom surveillance cameras >> - IP-TV using MPEG-TS and RTSP/RTCP/RTP protocols >> Also, rtmpd can be used as a high performance rendes-vous server. >> For example, it enables you to do: >> - Audio/Video conferencing >> - Online gaming >> - Online collaboration >> - Simple/complex chat applications >>=20 >> WWW: http://www.rtmpd.com >>=20 >> PR: ports/155033 = http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D155033 >> Submitted by: Gavriloaie Eugen-Andrei<crtmpserver@gmail.com> >>=20 >> Revision Changes Path >> 1.2320 +1 -0 ports/net/Makefile >> 1.1 +39 -0 ports/net/crtmpserver/Makefile (new) >> 1.1 +2 -0 ports/net/crtmpserver/distinfo (new) >> 1.1 +37 -0 ports/net/crtmpserver/files/crtmpserver.in = (new) >> 1.1 +15 -0 ports/net/crtmpserver/pkg-descr (new) >> 1.1 +27 -0 ports/net/crtmpserver/pkg-plist (new) >>=20 >> = http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/Makefile.diff?&r1=3D1.2319= &r2=3D1.2320&f=3Dh >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/Makefile >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/distinfo >> = http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/files/crtmpser= ver.in >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/pkg-descr >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/pkg-plist >>=20 >=20 >=20 >=20 > --=20 >=20 > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go >=20 > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ >=20 > <crtmpserver.diff> ------ C++ RTMP Server Support Email: support@rtmpd.com Web: http://www.rtmpd.com --Apple-Mail-11-653024689--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4334F7BE-149D-47D4-960D-8CD50B96DB7D>