From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 25 22:10:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BEA016A40A for ; Mon, 25 Feb 2008 22:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 442B313C45A for ; Mon, 25 Feb 2008 22:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1PMA0gN001105 for ; Mon, 25 Feb 2008 22:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1PMA0Xw001104; Mon, 25 Feb 2008 22:10:00 GMT (envelope-from gnats) Resent-Date: Mon, 25 Feb 2008 22:10:00 GMT Resent-Message-Id: <200802252210.m1PMA0Xw001104@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Philip M. Gollucci" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7EC416A40A for ; Mon, 25 Feb 2008 22:00:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id ACA7813C467 for ; Mon, 25 Feb 2008 22:00:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m1PLw8Sd021869 for ; Mon, 25 Feb 2008 21:58:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m1PLw8oO021868; Mon, 25 Feb 2008 21:58:08 GMT (envelope-from nobody) Message-Id: <200802252158.m1PLw8oO021868@www.freebsd.org> Date: Mon, 25 Feb 2008 21:58:08 GMT From: "Philip M. Gollucci" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/121098: net-mgmt/nagios-plugins: [PATCH] WITHOUT_NLS=yes actually works X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2008 22:10:02 -0000 >Number: 121098 >Category: ports >Synopsis: net-mgmt/nagios-plugins: [PATCH] WITHOUT_NLS=yes actually works >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Feb 25 22:10:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Philip M. Gollucci >Release: 8.0-CURRENT >Organization: Riderway Inc. >Environment: FreeBSD philip.hq.rws 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Tue Nov 6 16:28:12 EST 2007 pgollucci@philip.hq.rws:/usr/obj/usr/src/sys/RIDERWAY i386 >Description: USE_GETTEXT=yes has to be in the conditional. Also, changed defined() to !defined to match idiom on in porters handbook. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/net-mgmt/nagios-plugins/Makefile,v retrieving revision 1.66 diff -u -r1.66 Makefile --- Makefile 18 Dec 2007 23:32:12 -0000 1.66 +++ Makefile 25 Feb 2008 21:47:51 -0000 @@ -18,7 +18,6 @@ USE_SUBMAKE= yes USE_GMAKE= yes USE_ICONV= yes -USE_GETTEXT= yes USE_PERL5= yes USE_AUTOTOOLS= aclocal:19 automake:19 autoconf:261 ACLOCAL_ARGS= --acdir=${ACLOCAL_DIR} -I m4 -I gl/m4 @@ -129,11 +128,12 @@ PLIST_SUB+= SUB_LDAP="@comment " .endif -.if defined(WITHOUT_NLS) +.if !defined(WITHOUT_NLS) +USE_GETTEXT= yes +PLIST_SUB+= NLS="" +.else CONFIGURE_ARGS+= --disable-nls PLIST_SUB+= NLS="@comment " -.else -PLIST_SUB+= NLS="" .endif post-patch: >Release-Note: >Audit-Trail: >Unformatted: