From owner-svn-src-all@freebsd.org Tue Jun 25 02:07:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D483615B48A1 for ; Tue, 25 Jun 2019 02:07:25 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 43AEA6B8A0; Tue, 25 Jun 2019 02:07:24 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x5P27M9F073081 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 24 Jun 2019 19:07:22 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id x5P27M9r073080; Mon, 24 Jun 2019 19:07:22 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Mon, 24 Jun 2019 19:07:22 -0700 From: Gleb Smirnoff To: Mark Johnston Cc: Gordon Tetlow , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r349198 - releng/12.0/sys/net Message-ID: <20190625020722.GS67242@FreeBSD.org> References: <201906191641.x5JGfIsY027804@repo.freebsd.org> <20190624212540.GQ67242@FreeBSD.org> <20190624222341.GB37940@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624222341.GB37940@raichu> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 43AEA6B8A0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.929,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 02:07:26 -0000 Mark, On Mon, Jun 24, 2019 at 06:23:41PM -0400, Mark Johnston wrote: M> > On Wed, Jun 19, 2019 at 04:41:18PM +0000, Gordon Tetlow wrote: M> > G> Author: gordon M> > G> Date: Wed Jun 19 16:41:18 2019 M> > G> New Revision: 349198 M> > G> URL: https://svnweb.freebsd.org/changeset/base/349198 M> > G> M> > G> Log: M> > G> Fix incorrect locking in networking stack. M> > G> M> > G> Approved by: so M> > G> Security: FreeBSD-EN-19:11.net M> > M> > do I understand correct that problem isn't applicable to head, since M> > it was accidentially covered in r340413? Either fix for stable or M> > r340413 aren't a good looking code. M> M> I don't know about "accidentally," but yes. The problem was that M> r340413 could not easily be MFCed. See D17996 and D19764. Copy-pasted my text to old one, if that makes any sense. What do you think about my plan suggested in previous email? -- Gleb Smirnoff