From owner-svn-ports-head@freebsd.org  Mon Oct 16 12:25:32 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBCE0E396B5;
 Mon, 16 Oct 2017 12:25:32 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 444927E98A;
 Mon, 16 Oct 2017 12:25:31 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id a7ff00e0
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Mon, 16 Oct 2017 06:25:30 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r452173 - head/mail/sa-utils
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201710160618.v9G6Itjl045638@repo.freebsd.org>
Date: Mon, 16 Oct 2017 06:25:28 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <54963C5F-E09B-41E5-ADC9-8F803CDB78B0@adamw.org>
References: <201710160618.v9G6Itjl045638@repo.freebsd.org>
To: Matthew Seaman <matthew@freebsd.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 12:25:32 -0000

> On 16 Oct, 2017, at 0:18, Matthew Seaman <matthew@freebsd.org> wrote:
>=20
> Author: matthew
> Date: Mon Oct 16 06:18:55 2017
> New Revision: 452173
> URL: https://svnweb.freebsd.org/changeset/ports/452173
>=20
> Log:
>  Switch to options helpers
>=20
> Modified:
>  head/mail/sa-utils/Makefile
>=20

Hi Matthew,

This:
> +OPTIONS_SUB=3D	yes

Is not the same as this:
> -.if ${PORT_OPTIONS:MSACOMPILE}
> -SUB_LIST+=3D	SACOMPILE=3DYES
> -.else
> -SUB_LIST+=3D	SACOMPILE=3DNO

SUB_LIST applies to the subbed files in files/, in this case =
files/sa-utils.in. OPTIONS_SUB applies to pkg-plist.

You can still do:

SACOMPILE_SUB_LIST=3D	SACOMPILE=3DYES
SACOMPILE_SUB_LIST_OFF=3D	SACOMPILE=3DNO

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org