Date: Tue, 27 Jan 2015 17:46:56 +0000 (UTC) From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r277797 - head/sys/netipsec Message-ID: <201501271746.t0RHkuxT063546@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ae Date: Tue Jan 27 17:46:55 2015 New Revision: 277797 URL: https://svnweb.freebsd.org/changeset/base/277797 Log: key_spdget uses key_setdumpsp() without SPTREE_RLOCK held (it uses referenced pointer to sp). Remove SPTREE_RLOCK_ASSERT from key_setdumpsp() to fix wrong assertion. Reported by: Emeric POUPON Obtained from: Yandex LLC Sponsored by: Yandex LLC Modified: head/sys/netipsec/key.c Modified: head/sys/netipsec/key.c ============================================================================== --- head/sys/netipsec/key.c Tue Jan 27 17:33:18 2015 (r277796) +++ head/sys/netipsec/key.c Tue Jan 27 17:46:55 2015 (r277797) @@ -2421,8 +2421,6 @@ key_setdumpsp(struct secpolicy *sp, u_in struct mbuf *result = NULL, *m; struct seclifetime lt; - SPTREE_RLOCK_ASSERT(); - m = key_setsadbmsg(type, 0, SADB_SATYPE_UNSPEC, seq, pid, sp->refcnt); if (!m) goto fail;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501271746.t0RHkuxT063546>