From owner-freebsd-ports@FreeBSD.ORG  Thu Jun  1 23:15:35 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6387416A50A
	for <freebsd-ports@freebsd.org>; Thu,  1 Jun 2006 23:15:35 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.FreeBSD.org (Postfix) with SMTP id CD49E43D45
	for <freebsd-ports@freebsd.org>; Thu,  1 Jun 2006 23:15:34 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 28782 invoked by uid 399); 1 Jun 2006 23:15:33 -0000
Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 1 Jun 2006 23:15:33 -0000
Message-ID: <447F7512.4070605@FreeBSD.org>
Date: Thu, 01 Jun 2006 16:15:30 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 1.5.0.2 (X11/20060507)
MIME-Version: 1.0
To: Paul Murphy <paul.murphy@cogeco.ca>
References: <447F68B4.7050503@cogeco.ca>
In-Reply-To: <447F68B4.7050503@cogeco.ca>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: gkovesdan@t-hosting.hu, freebsd-ports@freebsd.org
Subject: Re: security/amavisd-new startup script
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2006 23:15:37 -0000

Paul Murphy wrote:
>  I need to keep the amavisd-new pid file in a location other than the
> default (/var/amavis/amavisd.pid), so I have rewritten the amavis rc
> script to include a knob for 'pidfile'. Please consider the attached
> file for the amavisd-new port.

> # Set defaults
> : ${amavisd_enable:="NO"}

Better to use = instead of := here, and - instead of :- below. See the
porter's handbook for an explanation.

> pidfile=${amavisd_pid:-"/var/amavis/amavisd.pid"}
command=/usr/local/sbin/amavisd
command_args="> /dev/null 2>&1"

> required_files=/usr/local/etc/amavisd.conf

This section should all be above the load_rc_config line in the script.
Also, you need to do it like this:

stop_postcmd=${name}_poststop
amavisd_poststop()
{
	rm -f $pidfile
}

Otherwise it looks good!

Doug

-- 

    This .signature sanitized for your protection