From owner-freebsd-current@freebsd.org  Tue Jun 28 15:49:00 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 413AEB815F2;
 Tue, 28 Jun 2016 15:49:00 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5B6912F51;
 Tue, 28 Jun 2016 15:48:59 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 0FBE11FE022;
 Tue, 28 Jun 2016 17:48:51 +0200 (CEST)
Subject: Re: pkg SAT_SOLVER bugs
To: Baptiste Daroussin <bapt@FreeBSD.org>
References: <20150414200459.GE39658@ivaldir.etoilebsd.net>
 <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org>
 <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org>
 <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net>
Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, ports@FreeBSD.org,
 FreeBSD Current <freebsd-current@freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org>
Date: Tue, 28 Jun 2016 17:52:32 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2016 15:49:00 -0000

On 06/27/16 13:55, Baptiste Daroussin wrote:
> On Mon, Jun 27, 2016 at 12:38:02PM +0200, Hans Petter Selasky wrote:
>> Hi,
>>
>> I found some bugs in PKG with regard to the SAT_SOLVER environment variable.
>> Please find patch attached :-)
>>
>> Issues fixed:
>> 1) No need to use hash table when generating SAT rules for external solver.
>> Variables are already in a linear array. Fix encoding and decoding of SAT
>> data.
>> 2) Endless variable loop caused pkg to crash.
>> 3) it->inverse was checked for non-zero, while it should actually be checked
>> for -1 only. SAT rules produces were all negative.
>>
>> How to verify:
>>
>> make -C /usr/ports/math/picosat all install clean
>>
>> env SAT_SOLVER=picosat pkg upgrade
>>
>> --HPS
>
> Thank you I will look into shortly
>

Hi Baptiste,

Are you handling this one or do you want me to create an issue at 
github. Thank you!

--HPS