From nobody Tue Sep 9 17:30:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLrST4R8Vz67CTP; Tue, 09 Sep 2025 17:30:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLrST0bHDz3XP8; Tue, 09 Sep 2025 17:30:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757439033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W4/cqigY8kL1F+FdLz0HKfLOoJSdL3F61MD3aPaiuqo=; b=oYzq/33F+UtsVZU9dLQ/Pg90QwOGeAXli1ctmWSpv0Z6pvmeTxFtl9rsP+2zly81tx6I9P G7iwUEHShPWSXg5UXHVJRNN0Cl/OglH7XVhhA6RYM4I7ld20U434s5rHQxhwZJSOLrxwJx unmdbE6yDEJf4kligj+UTsZExZf0eXrFGYA0JCQxe0IPWilUKHxonbLtZJNi79siOA87pL GHcCpl1hInB52hW1YzwzCkIiBKdenYy7qwhnDEL4OvwJZCH+bi8uavmNFfTNUhAM3Mq7v3 m4pxu3TsvFPwI7WZ8HEFzyhMi6ux4PpyEGahuvGY5fwEG9F8yknH6+/yJMT6/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757439033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W4/cqigY8kL1F+FdLz0HKfLOoJSdL3F61MD3aPaiuqo=; b=Cg9bRq3yLLHTOrf45dcmS9g9aCiJtrFjc/gZZTKnQPpDTkIExcFR2vk7KgKcyfj7NUyYfp aOFNX/F+lKI3mxIvuWf9frEUlMRBeqe4Isby6jsC9GfUgS1yXsvhhYL89kH7BINjtVhMVU G98YvLCVcqPjoAKqw448Rul2ZBMG2nFrZy0/BudRG98yLAXmCZaVKRqcFIkn5qHdlvMzs2 SPutt5xjrfJdwuTSKa0chVXBdECIuovtqnVU8d9Sad7BoXcS/SIbfK18PfHE9PfEzagnWz 15fkkHK/EShF5A9AyOm6HGgPaN4j21Sk2wrs3zTe2oWEV4DBxgAkSWC9NJnqYQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757439033; a=rsa-sha256; cv=none; b=H7wAUjJaSorsI/dO2tdBauYmDy2P//Ndklyo8PwfVNFF4Vsgtkwqk5wS5lDuSpF7kp2ViV 2VgzFb+o4pdxoCdBwKp0MSTgYboIaG0UKnLOD6WOHPrHeWBN7SoJPdgrfKsrslYsLZuPwm mUNbY6NRH+tkI0FmnyArWHKlX+1PU18ooe0+EzcWLNUvnEed7jBETgV5Af3JCbDaXgdcCo Q/fOuodjgjv9Vpdn2z4HD5rA8E+hDFuBz9ON4m1N3KQDrx+U5XIu3VuPJpuJ0Gy0O45uMT g57jqsACNqt3OQL5r3Rblj1dqmnYv2f2lnTGZ8JkiDrf6E+dQ5arv1vD9pnMqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cLrSS4Vp0zmBL; Tue, 09 Sep 2025 17:30:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 589HUWUF019201; Tue, 9 Sep 2025 17:30:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 589HUWvX019198; Tue, 9 Sep 2025 17:30:32 GMT (envelope-from git) Date: Tue, 9 Sep 2025 17:30:32 GMT Message-Id: <202509091730.589HUWvX019198@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: cd9b43edd5a7 - main - loader/efi: return error from efi_find_framebuffer List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cd9b43edd5a716fdb764adc281a4a09c617148f0 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=cd9b43edd5a716fdb764adc281a4a09c617148f0 commit cd9b43edd5a716fdb764adc281a4a09c617148f0 Author: Ahmad Khalifa AuthorDate: 2025-09-09 17:19:33 +0000 Commit: Ahmad Khalifa CommitDate: 2025-09-09 17:19:33 +0000 loader/efi: return error from efi_find_framebuffer Also return actual errno values in other code paths. (suggested by tsoome) Reviewed by: tsoome, imp Differential Revision: https://reviews.freebsd.org/D52432 --- stand/efi/loader/framebuffer.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/stand/efi/loader/framebuffer.c b/stand/efi/loader/framebuffer.c index 141a29305f7c..fc61ed15ba3c 100644 --- a/stand/efi/loader/framebuffer.c +++ b/stand/efi/loader/framebuffer.c @@ -630,7 +630,7 @@ efi_find_framebuffer(teken_gfx_t *gfx_state) gfx_state->tg_fb_type = FB_UGA; gfx_state->tg_private = uga; } else { - return (1); + return (efi_status_to_errno(status)); } } @@ -644,9 +644,12 @@ efi_find_framebuffer(teken_gfx_t *gfx_state) break; default: - return (1); + return (EINVAL); } + if (rv != 0) + return (rv); + gfx_state->tg_fb.fb_addr = efifb.fb_addr; gfx_state->tg_fb.fb_size = efifb.fb_size; gfx_state->tg_fb.fb_height = efifb.fb_height;