From owner-freebsd-geom@FreeBSD.ORG  Thu Dec 30 19:39:22 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2F85416A4CE
	for <geom@freebsd.org>; Thu, 30 Dec 2004 19:39:22 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3CE3143D2D
	for <geom@freebsd.org>; Thu, 30 Dec 2004 19:39:21 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iBUJdKwA047025;
	Thu, 30 Dec 2004 20:39:20 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=)
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 30 Dec 2004 20:28:24 +0100."
             <xzpsm5nvb53.fsf@dwp.des.no> 
Date: Thu, 30 Dec 2004 20:39:20 +0100
Message-ID: <47024.1104435560@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: geom@freebsd.org
Subject: Re: GEOM_VOL panics when audio CD is present 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Dec 2004 19:39:22 -0000

In message <xzpsm5nvb53.fsf@dwp.des.no>, =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=
 writes:
>--=-=-=
>Content-Type: text/plain; charset=iso-8859-1
>Content-Transfer-Encoding: quoted-printable
>
>Any objections to the attached patch?  It's not the most efficient
>solution, but it is the one least likely to give us surprises down the
>road.

I think the right check is to make sure the sectorsize is a power
of two && > DEV_BSIZE.


	if (!powerof2(cp->provider->sectorsize) || 
	    cp->provider->sectorsize < DEV_BSIZE)
		return (EINVAL)

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.