From owner-cvs-all@FreeBSD.ORG Mon Apr 21 23:38:49 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83F98106566B; Mon, 21 Apr 2008 23:38:49 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 43ADB8FC14; Mon, 21 Apr 2008 23:38:49 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (bcdci1mm7w66t0k2@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id m3LNcmN1074317; Mon, 21 Apr 2008 16:38:48 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id m3LNclCK074316; Mon, 21 Apr 2008 16:38:48 -0700 (PDT) (envelope-from jmg) Date: Mon, 21 Apr 2008 16:38:47 -0700 From: John-Mark Gurney To: Scott Long Message-ID: <20080421233847.GM82555@funkthat.com> References: <200804201745.m3KHjWma066842@repoman.freebsd.org> <20080421213724.GL82555@funkthat.com> <480D0E44.9070201@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480D0E44.9070201@samsco.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Mon, 21 Apr 2008 16:38:49 -0700 (PDT) Cc: cvs-src@FreeBSD.org, "Bjoern A. Zeeb" , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Apr 2008 23:38:49 -0000 Scott Long wrote this message on Mon, Apr 21, 2008 at 15:59 -0600: > John-Mark Gurney wrote: > >Bjoern A. Zeeb wrote this message on Sun, Apr 20, 2008 at 17:45 +0000: > >>bz 2008-04-20 17:45:32 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/ata ata-all.c > >> Log: > >> devclass_get_maxunit() returns n+1 with n starting at 0. > >> So if we have channel 0..3 devclass_get_maxunit is 4. > >> > >> It's never been a problem as devclass_get_device() has > >> catched a possibly bad input. > > > >Any one object to changing: > >.Nm devclass_get_maxunit > >.Nd find the maximum unit number in the class > > > >to: > >.Nm devclass_get_maxunit > >.Nd find the next free unit number in the class > > That's not what it actually returns though. It returned the highest > allocated unit number plus 1. The unit numbering can be sparse, with > the next available unit number being less than the highest allocated > unit number. Yeh, that was partly about changing the description... Can you think of a better name besides devclass_get_maxunitplusone? > Most callers use this value as the limit in a for loop, hence why it's > convenient for it to return the +1. Yeh, but it definately does not return maxunit.. :) unitarraysize? Hmmm... find isn't a useful verb, since it doesn't do any finding... it returns a stored value... How about: .Nd return the max number of units in the class And then flush out the description about using it for an array? Though it doesn't solve the naming issue... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."