From owner-cvs-all@FreeBSD.ORG Mon May 30 17:38:24 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B238916A41C; Mon, 30 May 2005 17:38:24 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50AA143D48; Mon, 30 May 2005 17:38:21 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j4UHjcSk004881; Mon, 30 May 2005 11:45:39 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <429B4F5A.4050705@samsco.org> Date: Mon, 30 May 2005 11:37:30 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Robert Watson References: <200505300501.j4U51ikj070065@repoman.freebsd.org> <20050530091556.A52379@fledge.watson.org> In-Reply-To: <20050530091556.A52379@fledge.watson.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Scott Long , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/random probe.c src/sys/opencrypto deflate.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2005 17:38:24 -0000 Robert Watson wrote: > > On Mon, 30 May 2005, Scott Long wrote: > >> malloc.h relies on param.h for a definition of MAXCPU. I guess that >> there is >> other header pollution that makes this work right now, but it falls >> over when >> doing a RELENG_5 -> HEAD upgrade. > > > Odd -- I added a nested include of param.h from malloc.h to catch this. > While almost certainly a bad idea (your fix is better), if you had the > latest revision of malloc.h, it shouldn't have broken the build... Was > your malloc.h slightly stale, or is there more to it than that? > > I'll basck out my change to malloc.h now that the dependencies are > fixed. Thanks! > > Robert N M Watson Maybe I did have a stale tree. I can't check it now since I already did another source update. Thanks for the explaination, though. Scott