From owner-freebsd-current@FreeBSD.ORG  Sun Feb  6 12:35:42 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BEB9616A4CE
	for <freebsd-current@freebsd.org>;
	Sun,  6 Feb 2005 12:35:42 +0000 (GMT)
Received: from smsgw.vianetworks.ch (smsgw.vianetworks.ch [146.228.10.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0157F43D31
	for <freebsd-current@freebsd.org>;
	Sun,  6 Feb 2005 12:35:42 +0000 (GMT)
	(envelope-from mw@smsgw.vianetworks.ch)
Received: from smsgw.vianetworks.ch (localhost.kpnqwest.ch [127.0.0.1])
	by smsgw.vianetworks.ch (8.12.10/8.12.6) with ESMTP id j16CZeNQ039989
	for <freebsd-current@freebsd.org>;
	Sun, 6 Feb 2005 13:35:40 +0100 (CET)
	(envelope-from mw@smsgw.vianetworks.ch)
Received: (from mw@localhost)
	by smsgw.vianetworks.ch (8.12.10/8.12.6/Submit) id j16CZemN039988
	for freebsd-current@freebsd.org; Sun, 6 Feb 2005 13:35:40 +0100 (CET)
Message-Id: <200502061235.j16CZemN039988@smsgw.vianetworks.ch>
In-Reply-To: <20050206120657.GB22743@dragon.nuxi.com>
To: freebsd-current@freebsd.org
Date: Sun, 6 Feb 2005 13:35:40 +0100 (CET)
Sender: mw@smsgw.vianetworks.ch
From: mw@kpnqwest.ch
X-NCC-RegID: ch.vianetworks
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Subject: Re: logitec usb wireless mouse
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Feb 2005 12:35:42 -0000

> > +       bzero (&h, sizeof (h));
> >         for (d = hid_start_parse(buf, len, 1<<k); hid_get_item(d, &h); )
> > -               if (h.report_ID != 0)
> > +               if (h.report_ID != 0 && !id)
> 
> Is the real magic the "&& !id"?  My read of the code doesn't see the need
> for the bzero as hid_get_item should be filling 'h'.

Yup, I'm just the paranoid type of person who likes to have properly
(as opposed to magically;-)) initialized structures.

Markus