From owner-freebsd-stable@freebsd.org Mon Jul 27 19:01:51 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F251936C15C for ; Mon, 27 Jul 2020 19:01:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BFq0t6MV2z4DMb for ; Mon, 27 Jul 2020 19:01:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd30.google.com with SMTP id w12so4514116iom.4 for ; Mon, 27 Jul 2020 12:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CkYk2kEahxdltpO60ppXlkmMQUgVcKxkVbEczMNaRZM=; b=u+ITnjuwNgAfYJzb1LSNAuyZF5na/5lZea4Mh4Oc10wn9yZkkGOnCHLGmODjLhmHyt Y80xDBQ2hbKhMcJbN9s5h/y9mybzBUtfa99kAhYyKiXsFNaN5kehVv9DqhdSzBs2E+UQ 2sus/mKkQKCg8g4C5b3L7po5RQlQWossMKF+m5YenySIYewlw7spTEiTTZhsGvGSTM1g B9usNUxavvQ7fGS+eqH4l+yFa5LMTBymutohYWN3e4rmCTrKXvvmC/srIDBnjP/Gls05 lsTdVw8SmI06zkg5zSn2uuRQAWzE21hRLh+139XZ16yseNHahYGOXMBulMnMI38erieE cs9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=CkYk2kEahxdltpO60ppXlkmMQUgVcKxkVbEczMNaRZM=; b=Ley1Tw81EkMvZGtvZHsN265U5p2CCYKez+Bt7O9wGAqjrOHNM0j8M7eqw7POmeiU8o vFnHiNhUF1P9Ngg/NwQDL7rHZBA/bxu5/T/LkaM6V7hBtrW3xgMEvLWf5DuE8sroDMgg egBEP0xIDJUXSUM/UILLR270ekUZPrbQoKkeYnKT/p4DEnZylj86KYuYXgGAYGKG+8ey MW7wIe6Vecyqi9bPma2D8gCECpWhtt9my/Q6/oMIgySYCzaWzyR2mKtQn/JdMwAOjUFE UHVRySgz2lQtE+/6KJy9G85OPcO7jOUywvS0RqAwX3fkKoZTF05Pw2uN1BAJnmo4Xmm6 eCkA== X-Gm-Message-State: AOAM530EjE98uFrxG46lGX7JXN19B4QeP8sMt71kX3eBUVZxTSERxkrl BlGrWGGvEr18YUI/ddnzgNYdL1qoqQ8= X-Google-Smtp-Source: ABdhPJyPiPY4+oD+YHFm9YD5M79CUFbC5ri9EO6QYHvJvu0gnZb8JrsXVXg4kbCSICONwcEqxPadqg== X-Received: by 2002:a6b:b54e:: with SMTP id e75mr25600866iof.31.1595876509753; Mon, 27 Jul 2020 12:01:49 -0700 (PDT) Received: from raichu (toroon0560w-lp130-08-67-71-176-35.dsl.bell.ca. [67.71.176.35]) by smtp.gmail.com with ESMTPSA id l11sm4849299ioh.52.2020.07.27.12.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 12:01:48 -0700 (PDT) Sender: Mark Johnston Date: Mon, 27 Jul 2020 15:01:47 -0400 From: Mark Johnston To: Joe Clarke Cc: freebsd-stable@freebsd.org Subject: Re: Traffic "corruption" in 12-stable Message-ID: <20200727190147.GC59953@raichu> References: <9FAE54DE-F409-4A53-B91E-59AE52A86513@marcuscom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9FAE54DE-F409-4A53-B91E-59AE52A86513@marcuscom.com> X-Rspamd-Queue-Id: 4BFq0t6MV2z4DMb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=u+ITnjuw; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d30 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.05 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.003]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-0.97)[-0.966]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d30:from]; NEURAL_HAM_SHORT(-0.38)[-0.381]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 19:01:52 -0000 On Sun, Jul 26, 2020 at 06:16:07PM -0400, Joe Clarke wrote: > About two weeks ago, I upgraded from the latest 11-stable to the latest 12-stable. After that, I periodically see the network throughput come to a near standstill. This FreeBSD machine is an ESXi VM with two interfaces. It acts as a router. It uses vmxnet3 interfaces for both LAN and WAN. It runs ipfw with in-kernel NAT. The LAN side uses a bridge with vmx0 and a tap0 L2 VPN interface. My LAN side uses an MTU of 9000, and my vmx1 (WAN side) uses the default 1500. > > Besides seeing massive packet loss and huge latency (~ 200 ms for on-LAN ping times), I know the problem has occurred because my lldpd reports: > > Jul 26 15:47:03 namale lldpd[1126]: frame too short for tlv received on bridge0 > > And if I turn on ipfw verbose messages, I see tons of: > > Jul 26 16:02:23 namale kernel: ipfw: pullup failed > > This leads to me to believe packets are being corrupted on ingress. I’ve applied all the recent iflib changes, but the problem persists. What causes it, I don’t know. > > The only thing that changed (and yes, it’s a big one) is I upgraded to 12-stable. Meaning, the rest of the network infra and topology has remained the same. This did not happen at all in 11-stable. > > I’m open to suggestions. There are some fixes for vmx not present in stable/12 (yet). I did a merge of a number of outstanding revisions. Would you be able to test the patch? I haven't observed any problems with it on a host using igb, but I have no ability to test vmx at the moment. https://people.freebsd.org/~markj/patches/iflib-stable12.diff