From owner-freebsd-wireless@FreeBSD.ORG  Thu Aug 18 02:31:51 2011
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C6364106564A
	for <freebsd-wireless@freebsd.org>;
	Thu, 18 Aug 2011 02:31:51 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 8585C8FC0C
	for <freebsd-wireless@freebsd.org>;
	Thu, 18 Aug 2011 02:31:51 +0000 (UTC)
Received: by gwb15 with SMTP id 15so743437gwb.13
	for <freebsd-wireless@freebsd.org>;
	Wed, 17 Aug 2011 19:31:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=IGLoaNlbI/l++wWoJBJrV5paqyLoqH5TwCH8anc2z7o=;
	b=P6iCQmHeyuS0lIcVwap9bF8+J/6lY3UB0CgWewoa5O9oPa0kLyQtSNJD41pROdFbmk
	qYOzOOe4EnPFRb/RXnwgBjLxAcxLgCzDS5IeET/R2nI6PjvfsmDDPaaJDtlWgpo9mpt3
	2U9PQFJx/qedwn8PudrE2hkhbt1kgYTA8ecYo=
MIME-Version: 1.0
Received: by 10.150.72.23 with SMTP id u23mr162828yba.443.1313634710780; Wed,
	17 Aug 2011 19:31:50 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.150.145.21 with HTTP; Wed, 17 Aug 2011 19:31:50 -0700 (PDT)
In-Reply-To: <CAFZ_MYLPnH=wMF1uiLCV08LnQztPBA-OkQ8zVKSvp7ZHm+vJ1Q@mail.gmail.com>
References: <CAFZ_MYJGv8zhJLaAjs_o2mxjjopYofSoymgwfMnO-79nKub66w@mail.gmail.com>
	<CAJ-VmomS+o+vJTjCC26FoXHf6JESDofLgZH4vZRSRKNM3ZgVkQ@mail.gmail.com>
	<CAFZ_MYLPnH=wMF1uiLCV08LnQztPBA-OkQ8zVKSvp7ZHm+vJ1Q@mail.gmail.com>
Date: Thu, 18 Aug 2011 10:31:50 +0800
X-Google-Sender-Auth: dlOe2yZQMKa3zxYVHfOZyWTkX1o
Message-ID: <CAJ-Vmonw=4K4wNo64zU5UDgWkp4zc9P2v90sY1F1ZYWDfaCTsg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: PseudoCylon <moonlightakkiy@yahoo.ca>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-wireless@freebsd.org
Subject: Re: ieee80211_process_callback() use in drivers
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Aug 2011 02:31:51 -0000

On 18 August 2011 10:10, PseudoCylon <moonlightakkiy@yahoo.ca> wrote:

>> Hm, I fixed the status check in the BAR TX routines.
>> Is that enough? Or are you saying that the node ref is freed somewhere
>> inside ic_raw_xmit() on a TX failure?
>
> Sorry, I found the commit after replied.
>
> But, drivers call ieee80211_free_node() in ic_raw_xmit() on failure.

Hm, so we can't kill the free, because ieee80211_ref_node() is called early on.
So if ic->ic_raw_xmit(), just return ret, rather then "goto bad" ?


Adrian