Date: Wed, 6 Mar 2002 02:08:07 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: "David O'Brien" <obrien@freebsd.org> Cc: hackers@freebsd.org Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Message-ID: <20020306000806.GC6839@hades.hell.gr> In-Reply-To: <20020305155850.A38095@dragon.nuxi.com> References: <20020305201350.GC4820@hades.hell.gr> <20020305155850.A38095@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2002-03-05 15:58, David O'Brien wrote:
> On Tue, Mar 05, 2002 at 10:13:50PM +0200, Giorgos Keramidas wrote:
> > > -Don't use '!' for tests unless it's a boolean, e.g. use
> > > +For tests, always compare the value to the appropriate 0 instead of
> > > +checking it directly, unless the value is a boolean.
...
>
> Please show examples from /sys that back up this change. To state this
> explicitly, I think a significant number of /sys files should be
> following it.
Actually I was asking for comments, but anyways. I will try to skim
through the sources, and look for conditionals, to get the general
feel of what is being used. I should note though, that I'm neither
supporting or against this change. I'll see what I can do, and
hopefully be able to post a followup sooner or later.
Giorgos Keramidas FreeBSD Documentation Project
keramida@{freebsd.org,ceid.upatras.gr} http://www.FreeBSD.org/docproj/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
iD8DBQE8hV3m1g+UGjGGA7YRAnTFAJ9Ua0RAbgerbZmWfFAledzJ5xofCACfeiMe
CbFAB4YXaf4r37+6Hn8Ye88=
=uL9x
-----END PGP SIGNATURE-----
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020306000806.GC6839>