From owner-freebsd-bugs@freebsd.org Sat Jan 14 23:07:44 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6DD2CAF09C for ; Sat, 14 Jan 2017 23:07:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9CB3B120F for ; Sat, 14 Jan 2017 23:07:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0EN7iHE090165 for ; Sat, 14 Jan 2017 23:07:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 216088] Get NFSv4.1 client's failure during recovery keep unrecovered opens Date: Sat, 14 Jan 2017 23:07:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 23:07:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216088 Bug ID: 216088 Summary: Get NFSv4.1 client's failure during recovery keep unrecovered opens Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: rmacklem@FreeBSD.org Created attachment 178896 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D178896&action= =3Dedit Don't free unrecovered opens when recovery of them fails When the NFSv4.1 client is recovering from a server crash/reboot and the recovery of opens fails, the code in current free's the unrecovered opens. Byte range locks cannot be kept, since a conflicting lock might have been acquired by a different client while it is not recovered. The server is supposed to not allow a recovery when it has previously not been recovered. However, since all opens for POSIX clients are Share_Deny_None, it seems safe to attempt to recover them again, in case the server allows this. This patch changes the client recovery code so that it retains unrecovered opens, so a subsequent recovery can attempt to recover them. Normally, this should not happen, but the AmazonEFS server crashes/reboots frequently, including while recovery is still being done. --=20 You are receiving this mail because: You are the assignee for the bug.=